Fix TYC API pagination to retrieve all ICP domain pages #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYC API queries for ICP domain records were only returning the first page of results due to hardcoded pagination metadata.
Changes
internal/tycapi/tycapi.goSizefield dynamically to actual items returned (len(items)) instead of hardcoded20pages = (total + size - 1) / sizeThis aligns with the pattern used in other providers (aiqicha, kuaicha) where
Sizereflects per-page item count for pagination logic inrunner/enscan.go.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.