Fix race condition causing "panic: send on closed channel" #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Race condition between worker goroutines adding tasks and main goroutine closing the task channel causes panic when processing deep search results.
Failure sequence:
Changes
closedflag toEnJobstruct to track channel lifecycleAddTask()andreTaskQueue(): Check closed flag under lock, increment wait group, release lock, then send to channelcloseCH(): Set closed flag before closing channels, prevent double-closeSafety
Wait group increment happens before lock release. Since
closeCH()is only called afterwg.Wait()completes, the channel is guaranteed open during send:Lock is released before channel send to prevent deadlock when channel is full.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.