Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot How does the extension rearrange tabs without this permission? Can you explain with links to the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. It still works because the extension only uses tab operations + non-sensitive tab fields, which are allowed without the
tabspermission.Code paths:
getTabs()→background.js#L49-L51id+active):background.js#L62-L76chrome.tabs.move(...):background.js#L149-L160chrome.tabs.update(..., { active: true }):background.js#L166-L194It does not read restricted fields like
url,title,favIconUrl, etc., so broadtabspermission is unnecessary here. The permission change is in commit012afc9.