feat: add localMode option to CloudStorageService - #18
Open
aandre35 wants to merge 2 commits into
Open
Conversation
Replace implicit filesystem-based local file detection with an explicit `localMode` flag in CloudStorageServiceOptions. Connectors can now set LOCAL_FILE=true in their .env and pass it to the SDK, making the local-vs-GCS behavior deterministic and easier to debug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PoulpiFr
reviewed
Jul 21, 2026
| { | ||
| "name": "@whaly/connector-sdk", | ||
| "version": "0.3.10", | ||
| "version": "0.3.8", |
Contributor
There was a problem hiding this comment.
Can you remove this? It'll conflict with current version (0.3.11).
I think that it's better to do another separate PR to ship a new version / release, otherwise stale PR are becoming impossible to merge without updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localModeoption toCloudStorageServicethat allows resolving file URIs to local paths instead of downloading from GCSresolveFileUri()method that either resolves locally or downloads from GCS depending on the modeTest plan
resolveFileUridownloads from GCS whenlocalModeis not setresolveFileUriresolves local paths whenlocalMode: true🤖 Generated with Claude Code