Repository navigation
feat: offer Serbia instead of Croatia in both sample apps - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Also, you did croatia as the country in demo react app, can you please update that to Serbia, I am Serbian.
Context for that statement: the demo React app is
react-checkoutin this repository. Its checkout form has a country choice that offers Austria, Croatia and Germany.Later, after being told that both demos (
react-checkoutandvue-event-registration) have the Croatia option and that both were being changed:Yes replace Croatia with Serbia
Later, asked whether the sample people and company names used in both demos' test data (Croatian-looking names such as Jana Kovač, Ana Horvat, Ivo Horvat, Mia Novak, Kovač d.o.o. and Horvat d.o.o., with their example.com email addresses) should also change:
Swap it with common Serbian names
What Changed
react-checkoutandvue-event-registrationnow offers Serbia (RS) in place of Croatia (HR): the form definitions, thecountryunion types, and the English and German labels inreact-checkout/shared/i18n.ts(Serbia/Serbien) are all updated.Belgradin German), and the phone format hint in the Vue registration form uses+381 61 234 5678as its example.Knez Mihailova 1,11000), anRSVAT ID, and Serbian sample people and companies (Jelena Jovanović, Marko Petrović, Nikola Petrović, Milica Nikolić, Jovanović d.o.o., Petrović d.o.o.) with matching example.com emails.Risk Assessment
✅ Low: A consistent data-only swap of HR/Croatia to RS/Serbia across option values, both locales' label keys, TypeScript unions and test fixtures, with no leftover Croatian references and new sample values (zip 11000, VAT ID RS123456789, phone +381...) that satisfy the existing validation patterns.
Testing
Installed dependencies for both demos, then ran each demo's existing Playwright end-to-end suite against its production build (react-checkout 12 passed, vue-event-registration 8 passed, desktop and mobile). I then started both production apps locally and drove them in Chromium with a throwaway script: read the country dropdown options in English and German, placed a Serbia order, posted HR and RS straight to the checkout API, triggered the phone validation message, and completed a business registration billed to Serbia, capturing seven screenshots. Croatia is gone from both dropdowns, the server rejects HR with a 422, and no Croatian names, Zagreb or +385 references remain in the repo. Servers were stopped and build outputs removed from the worktree.
Evidence: Values read from the running apps (dropdown options, confirmed order, API responses)
Evidence: Country dropdown options and API guard, read from the running apps
Evidence: react-checkout Playwright run
Evidence: vue-event-registration Playwright run
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
react-checkout/shared/i18n.ts:22- Besides the requested country option and sample names, the change also updates two pieces of user-visible copy that the intent does not name literally: the checkout lead 'shipped from Zagreb' -> 'Belgrade' (react-checkout/shared/i18n.ts:22 and :112 for German) and the phone example '+385 91 234 5678' -> '+381 61 234 5678' (vue-event-registration/src/registration/definition.json:39). Both are consistent with the stated goal of making the demos Serbian and are covered by the updated tests, so no action is needed.✅ **Test** - passed
✅ No issues found.
pnpm install --frozen-lockfileinreact-checkoutandvue-event-registrationpnpm exec playwright testinreact-checkout(12 passed, exit 0)pnpm exec playwright testinvue-event-registration(8 passed, exit 0)PORT=4274 pnpm start(react-checkout production build) andpnpm exec vite preview --port 4273 --strictPort(vue-event-registration production build), driven bynode drive.cjsin Chromium: country options, Serbia order, German locale, phone message, business registration, screenshotsPOST /api/orderson the running react-checkout server withshipping.countryset toHR(422) andRS(201)git grep -i -E "croat|kroat|zagreb|'HR'|horvat|kovač|novak|\+385"over the repo: no matches✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.