Skip to content

fix: move sample apps to design-system 0.8.0 and drop covered workarounds - #7

Merged
whatsaaaa merged 1 commit into
mainfrom
fm/samples-ds-080
Nov 16, 2026
Merged

whatsaaaa merged 1 commit into
mainfrom
fm/samples-ds-080

Conversation

@whatsaaaa

@whatsaaaa whatsaaaa commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Intent

Move the Vue and React sample apps to design system 0.8.0, which closes the gaps found when they adopted 0.6.1 in #6 (whatsaaaa/design-system#23), and drop the local workarounds the release now covers, following its migration notes.

What Changed

  • Moved react-checkout and vue-event-registration from @whatsaaaa/design-system ^0.6.1 to ^0.8.0 (package.json, lockfiles, minimumReleaseAgeExclude). Both apps' Vite head plugins now also add the package's themeColorMeta theme-color tags ahead of the theme and keys init scripts.
  • Removed local CSS workarounds that the release now covers. The --page-gutter variable is gone and its 20px and 16px values (--ws-space-20 / --ws-space-16) are set directly, with the 16px phone gutter applied below 64rem. Icon sizes use --ws-size-icon instead of --ws-space-16/1rem, and the Vue date picker uses --ws-icon-calendar instead of its own inline SVG --icon-calendar.
  • Fields in a row now stack only below 40rem (it was 64rem). In React, .row--sections columns still stack below 64rem. The Vue review summary (SummaryList.vue) is now a single ws-pairs-group with no per-section <section> wrappers, so values in every section line up. The spacing between sections now comes from a top margin on each section title.

🤖 Generated with Claude Code

Workarounds, one by one

Removed in both apps unless noted:

  • Phone gutter: the app's own --page-gutter is gone. The content is padded --ws-space-20 from 64rem and --ws-space-16, the phone gutter the usage guide names, below it. Neither app had a pane padded 20px below 64rem (groups were already 16px), so nothing moved.
  • Icon size: the tick on a checkbox, the done-step tick (Vue), the error icon of a field and the icon of a notice now use --ws-size-icon.
  • Calendar icon (Vue only, as React has no date field): --ws-icon-calendar replaces the app's own.
  • Rows of fields stack below 40rem, not 64rem. React's page columns (row--sections) still stack below 64rem, since a page has one column there.
  • Review step (Vue only, as React has no review step and its order summary is one ws-pairs--amounts list): the Confirm lists are in one ws-pairs-group. The <section> wrappers are gone because the group needs the headings and lists as its children. The 24px between sections is now the title's top margin.
  • theme-color tags: neither app set them by hand. Both Vite plugins now write the two tags from themeColorMeta, as the usage guide's plugin does.
  • Status line padding on a phone: neither app had a local rule, so there was nothing to drop. The release pads the items 10px itself.

Kept:

  • minimumReleaseAgeExclude keeps an entry for @whatsaaaa/design-system@0.8.0 (in place of 0.6.1): pnpm 11 refuses the release without it, as it was published on 2026-11-15.
  • The radio button's dot at --ws-space-8: a dot, not an icon, and the system has no token for it.
  • The error notice's title icon at --ws-space-20: a 20px icon, deliberately larger than the 16px icon size.

Design-system gaps still open: none found.

Visible changes

I screenshotted both apps on main and on this branch, in both themes, at 320, 390, 768 and 1440px, including a date field and the Vue Confirm step, and pixel-diffed them. Each change that shows is one the 0.8.0 notes intend:

  • Status line on a phone (320, 390): items padded 10px instead of 14, so the path shows more.
  • Vue date field: the system's calendar icon, which is drawn on the 16px grid and so a little smaller.
  • 768px: fields share rows (Vue: first and last name, email and phone, arrival and departure, the invoice rows; React: product and quantity, postal code and city), so pages are shorter.
  • Vue Confirm: the values of every section start at one edge, with the term column as wide as the longest term (at most 40%). On a phone a few values wrap one line more (+24px).

Everything else is pixel-identical. The only other differences are a few anti-aliased pixels on radio and input edges, which also differ between two runs of main. The built HTML as sent (fetched without JavaScript) carries both theme-color tags in both apps, #191724 for dark first and #faf4ed for a light system. In the browser there are exactly two, and they follow the theme switch.

Risk Assessment

✅ Low: A narrow dependency bump with CSS and head-tag migrations that match the published design-system 0.8.0 usage docs one for one, and the visible behavior is unchanged except for what the intent asks for: rows now stack below 40rem, the review sections share one term column, and theme-color tags are sent with the page.

Testing

I built both apps for production and served them the way users run them: Vue on vite preview :4273, React on its own Node server :4274. A Chromium script made 50 live checks at widths from 320px to 1280px, all passing, with screenshots, and it tested the boundaries on both sides: 1023/1024px for 64rem and 639/640px for 40rem. The checks covered: theme-color tags as sent and with JavaScript off; theme-color following a manual theme switch and a reload with no extra tag added; the gutter lining up with the brand and the bar's end; rows sharing a line or stacking at each breakpoint; React's page columns; icon sizes and the calendar mask (read over CDP from the date input's shadow tree); Confirm-section alignment with 4 sections; and status line padding. The existing Playwright frame, fit-the-screen, happy-path and forced-colors specs also passed against the same servers on both desktop and mobile: Vue 19 passed and React 31 passed, each with 1 skipped by design (the t-key test is desktop-only). The servers are stopped, and dist/ and the test outputs are removed.

  • Live validation: ✅ go - 10 of 10 scenarios driven live against the product
Scenario Result Live Evidence
Both apps install and build on @whatsaaaa/design-system 0.8.0 from the committed lockfile ✅ pass live pnpm install --frozen-lockfile then pnpm build succeeded in both apps; node_modules/@whatsaaaa/design-system/package.json reports 0.8.0
Served page (vite preview :4273 / Node server :4274) carries the two theme-color tags from themeColorMeta, dark #191724 first, then light #faf4ed, before the head scripts, including with JavaScript of… ✅ pass live vue-served-index.html, react-served-index.html; drive-transcript.txt 'with JavaScript off the served page has the dark tag first, then the light one' (both apps)
Switching the theme by hand in the status line updates both theme-color tags to the theme shown, survives a reload, and adds no extra tag (both apps) ✅ pass live drive-transcript.txt 'two theme-color tags follow the theme switched by hand' for vue and react; frame.spec 'switches the theme, and remembers it' passed in both e2e transcripts
Form content and first input line up with the tab bar's brand and end: 20px gutter at 1280/1024px, the design system's 16px phone gutter at 1023/800/390/320px, no sideways scroll (both apps) ✅ pass live drive-transcript.txt gutter checks (12 PASS); vue-390-first-view.png, react-390-first-view.png, *-1280-first-view.png
Rows of fields share a line from 40rem (640px) up and stack below (639px, 390px); React's page columns still stack below 64rem (1023px) and sit side by side at 1024px+ ✅ pass live drive-transcript.txt row checks (12 PASS); vue-800-row.png, vue-639-row.png, react-800-rows.png, react-639-rows.png
Vue date picker button draws the design system's --ws-icon-calendar at 16px (local --icon-calendar removed) ✅ pass live drive-transcript.txt 'date picker button is 16px, masked with the design system's --ws-icon-calendar' (2 indicators, mask equals the DS token); vue-date-row-calendar-icons.png
Icons next to text draw at --ws-size-icon (16px): field error icons, checkbox ticks, Vue done-step ticks (radio dots stay 8px) ✅ pass live drive-transcript.txt icon checks (vue error/done tick/checkbox, react error/checkbox); react-390-errors-and-icons.png, vue-1280-confirm-full-window-dark.png (done-step ticks)
Vue Confirm step: all 4 review sections (About you, Your visit, Guests, Invoice) share one term column, so every value starts at one x; titles take their own row; 24px between sections; no overflow at… ✅ pass live drive-transcript.txt Confirm checks (single dd left per width: 508/297/177.8); vue-1280-confirm-full-window-dark.png, vue-800-confirm-summary.png, vue-390-confirm-summary.png; registration fit e2e pas…
Status line pads its items 14px from 64rem up and 10px below, and stays whole from 320 to 400px with keys on and off (both apps) ✅ pass live drive-transcript.txt status line padding checks (12 PASS); frame.spec 'keeps the status line whole on a narrow screen' passed in both e2e transcripts
Existing end-to-end flows still work on 0.8.0: Vue registration happy path and fit-the-screen at 320/390px; React order placement, fit-the-screen in EN/DE, forced-colors states ✅ pass live vue-e2e-transcript.txt (19 passed, 1 skipped), react-e2e-transcript.txt (31 passed, 1 skipped)
Evidence: Live check transcript (50/50 pass)
PASS  vue 1280px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end  {"barPad":"20px","brandPad":"10px","contentPad":"20px/20px","brandStart":240,"markPixelsStart":240,"contentStart":240,"inputLeft":240,"barEnd":1040,"contentEnd":1040,"overflow":0}
PASS  vue 1280px: status line pads its items 14px  {"mode":"14px"}
PASS  vue 1024px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end  {"barPad":"20px","brandPad":"10px","contentPad":"20px/20px","brandStart":112,"markPixelsStart":112,"contentStart":112,"inputLeft":112,"barEnd":912,"contentEnd":912,"overflow":0}
PASS  vue 1024px: status line pads its items 14px  {"mode":"14px"}
PASS  vue 1023px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":111.5,"markPixelsStart":111.5,"contentStart":111.5,"inputLeft":111.5,"barEnd":911.5,"contentEnd":911.5,"overflow":0}
PASS  vue 1023px: status line pads its items 10px  {"mode":"10px"}
PASS  vue 800px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":29,"markPixelsStart":29,"contentStart":29,"inputLeft":29,"barEnd":771,"contentEnd":771,"overflow":0}
PASS  vue 800px: status line pads its items 10px  {"mode":"10px"}
PASS  vue 390px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":29,"markPixelsStart":29,"contentStart":29,"inputLeft":29,"barEnd":361,"contentEnd":361,"overflow":0}
PASS  vue 390px: status line pads its items 10px  {"mode":"10px"}
PASS  vue 320px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":29,"markPixelsStart":29,"contentStart":29,"inputLeft":29,"barEnd":291,"contentEnd":291,"overflow":0}
PASS  vue 320px: status line pads its items 10px  {"mode":"10px"}
PASS  react 1280px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end  {"barPad":"20px","brandPad":"10px","contentPad":"20px/20px","brandStart":240,"markPixelsStart":240,"contentStart":240,"inputLeft":240,"barEnd":1040,"contentEnd":1040,"overflow":0}
PASS  react 1280px: status line pads its items 14px  {"mode":"14px"}
PASS  react 1024px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end  {"barPad":"20px","brandPad":"10px","contentPad":"20px/20px","brandStart":112,"markPixelsStart":112,"contentStart":112,"inputLeft":112,"barEnd":912,"contentEnd":912,"overflow":0}
PASS  react 1024px: status line pads its items 14px  {"mode":"14px"}
PASS  react 1023px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":111.5,"markPixelsStart":111.5,"contentStart":111.5,"inputLeft":111.5,"barEnd":911.5,"contentEnd":911.5,"overflow":0}
PASS  react 1023px: status line pads its items 10px  {"mode":"10px"}
PASS  react 800px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":29,"markPixelsStart":29,"contentStart":29,"inputLeft":29,"barEnd":771,"contentEnd":771,"overflow":0}
PASS  react 800px: status line pads its items 10px  {"mode":"10px"}
PASS  react 390px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":29,"markPixelsStart":29,"contentStart":29,"inputLeft":29,"barEnd":361,"contentEnd":361,"overflow":0}
PASS  react 390px: status line pads its items 10px  {"mode":"10px"}
PASS  react 320px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end  {"barPad":"0px","brandPad":"16px","contentPad":"16px/16px","brandStart":29,"markPixelsStart":29,"contentStart":29,"inputLeft":29,"barEnd":291,"contentEnd":291,"overflow":0}
PASS  react 320px: status line pads its items 10px  {"mode":"10px"}
PASS  vue 1280px: First name / Last name share a row  {"first":{"top":383,"left":240,"width":392},"last":{"top":383,"left":648,"width":392}}
PASS  vue 800px: First name / Last name share a row  {"first":{"top":348,"left":29,"width":363},"last":{"top":348,"left":408,"width":363}}
PASS  vue 640px: First name / Last name share a row  {"first":{"top":348,"left":29,"width":283},"last":{"top":348,"left":328,"width":283}}
PASS  vue 639px: First name / Last name stack  {"first":{"top":348,"left":29,"width":581},"last":{"top":439,"left":29,"width":581}}
PASS  vue 390px: First name / Last name stack  {"first":{"top":414,"left":29,"width":332},"last":{"top":505,"left":29,"width":332}}
PASS  react 1280px: Postal code/City and Product/Quantity share a row; page columns side by side  {"zip":{"top":1232,"left":261,"width":125},"city":{"top":1232,"left":402,"width":267},"product":{"top":606,"left":261,"width":267},"qty":{"top":606,"left":544,"width":125},"cols":[{"top":223,"left":240},{"top":223,"left":730}]}
PASS  react 1024px: Postal code/City and Product/Quantity share a row; page columns side by side  {"zip":{"top":1232,"left":133,"width":125},"city":{"top":1232,"left":274,"width":267},"product":{"top":606,"left":133,"width":267},"qty":{"top":606,"left":416,"width":125},"cols":[{"top":223,"left":112},{"top":223,"left":602}]}
PASS  react 1023px: Postal code/City and Product/Quantity share a row; page columns stacked  {"zip":{"top":1235,"left":129,"width":245},"city":{"top":1235,"left":389,"width":505},"product":{"top":620,"left":129,"width":505},"qty":{"top":620,"left":650,"width":245},"cols":[{"top":246,"left":112},{"top":1613,"left":112}]}
PASS  react 800px: Postal code/City and Product/Quantity share a row; page columns stacked  {"zip":{"top":1235,"left":46,"width":225},"city":{"top":1235,"left":287,"width":467},"product":{"top":620,"left":46,"width":467},"qty":{"top":620,"left":529,"width":225},"cols":[{"top":246,"left":29},{"top":1613,"left":29}]}
PASS  react 640px: Postal code/City and Product/Quantity share a row; page columns stacked  {"zip":{"top":1235,"left":46,"width":172},"city":{"top":1235,"left":234,"width":360},"product":{"top":620,"left":46,"width":360},"qty":{"top":620,"left":422,"width":172},"cols":[{"top":246,"left":29},{"top":1613,"left":29}]}
PASS  react 639px: Postal code/City and Product/Quantity stack; page columns stacked  {"zip":{"top":1326,"left":46,"width":547},"city":{"top":1417,"left":46,"width":547},"product":{"top":620,"left":46,"width":547},"qty":{"top":711,"left":46,"width":547},"cols":[{"top":246,"left":29},{"top":1795,"left":29}]}
PASS  react 390px: Postal code/City and Product/Quantity stack; page columns stacked  {"zip":{"top":1326,"left":46,"width":298},"city":{"top":1417,"left":46,"width":298},"product":{"top":620,"left":46,"width":298},"qty":{"top":711,"left":46,"width":298},"cols":[{"top":246,"left":29},{"top":1795,"left":29}]}
PASS  vue: --ws-size-icon is 16px, --ws-icon-calendar comes from the design system, local --icon-calendar/--page-gutter gone  {"sizeIcon":"1rem","calendarDefined":true,"oldLocalCalendar":"","oldPageGutter":""}
PASS  vue: field error icon is 16px wide, masked at 16px  {"width":"16px","maskSize":"16px auto","maskImage":"url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"}
PASS  vue: done step tick is 16px  {"width":"16px","maskSize":"contain","maskImage":"url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"}
PASS  vue: date picker button is 16px, masked with the design system's --ws-icon-calendar  {"count":2,"width":"16px","height":"16px","maskImage":"url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' view","bg":"rgb(87, 82, 121)","allSame":true,"sameAsDsToken":true}
PASS  vue: checked box tick is 16px  {"width":"16px","maskSize":"contain","maskImage":"url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"}
PASS  react: field error icon is 16px wide, masked at 16px  {"width":"16px","maskSize":"16px auto","maskImage":"url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"}
PASS  react: checked box tick is 16px  {"width":"16px","maskSize":"contain","maskImage":"url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"}
PASS  vue 1280px Confirm: 4 summary sections share one value edge, titles take their own row, 24px between sections  {"sections":["About you","Your visit","Guests","Invoice"],"lists":4,"ddLefts":[508],"dtLefts":[240],"gapsBetweenSections":[24],"titlesFullWidth":true,"overflow":0}
PASS  vue 800px Confirm: 4 summary sections share one value edge, titles take their own row, 24px between sections  {"sections":["About you","Your visit","Guests","Invoice"],"lists":4,"ddLefts":[297],"dtLefts":[29],"gapsBetweenSections":[24],"titlesFullWidth":true,"overflow":0}
PASS  vue 390px Confirm: 4 summary sections share one value edge, titles take their own row, 24px between sections  {"sections":["About you","Your visit","Guests","Invoice"],"lists":4,"ddLefts":[177.8],"dtLefts":[29],"gapsBetweenSections":[24],"titlesFullWidth":true,"overflow":0}
PASS  vue: two theme-color tags follow the theme switched by hand (dark #191724, light #faf4ed), no extra tag added  {"before":["#faf4ed|not all and (prefers-color-scheme: light)","#faf4ed|(prefers-color-scheme: light)"],"dark":["#191724|not all and (prefers-color-scheme: light)","#191724|(prefers-color-scheme: light)"],"bodyBgDark":"rgb(25, 23, 36)","reloaded":["#191724|not all and (prefers-color-scheme: light)","#191724|(prefers-color-scheme: light)"],"light":["#faf4ed|not all and (prefers-color-scheme: light)","#faf4ed|(prefers-color-scheme: light)"]}
PASS  react: two theme-color tags follow the theme switched by hand (dark #191724, light #faf4ed), no extra tag added  {"before":["#faf4ed|not all and (prefers-color-scheme: light)","#faf4ed|(prefers-color-scheme: light)"],"dark":["#191724|not all and (prefers-color-scheme: light)","#191724|(prefers-color-scheme: light)"],"bodyBgDark":"rgb(25, 23, 36)","reloaded":["#191724|not all and (prefers-color-scheme: light)","#191724|(prefers-color-scheme: light)"],"light":["#faf4ed|not all and (prefers-color-scheme: light)","#faf4ed|(prefers-color-scheme: light)"]}
PASS  vue: with JavaScript off the served page has the dark tag first, then the light one  {"tags":["#191724|not all and (prefers-color-scheme: light)","#faf4ed|(prefers-color-scheme: light)"]}
PASS  react: with JavaScript off the served page has the dark tag first, then the light one  {"tags":["#191724|not all and (prefers-color-scheme: light)","#faf4ed|(prefers-color-scheme: light)"]}

50/50 checks passed
Evidence: Live check results with measurements
[
  {
    "name": "vue 1280px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "20px",
      "brandPad": "10px",
      "contentPad": "20px/20px",
      "brandStart": 240,
      "markPixelsStart": 240,
      "contentStart": 240,
      "inputLeft": 240,
      "barEnd": 1040,
      "contentEnd": 1040,
      "overflow": 0
    }
  },
  {
    "name": "vue 1280px: status line pads its items 14px",
    "ok": true,
    "detail": {
      "mode": "14px"
    }
  },
  {
    "name": "vue 1024px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "20px",
      "brandPad": "10px",
      "contentPad": "20px/20px",
      "brandStart": 112,
      "markPixelsStart": 112,
      "contentStart": 112,
      "inputLeft": 112,
      "barEnd": 912,
      "contentEnd": 912,
      "overflow": 0
    }
  },
  {
    "name": "vue 1024px: status line pads its items 14px",
    "ok": true,
    "detail": {
      "mode": "14px"
    }
  },
  {
    "name": "vue 1023px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 111.5,
      "markPixelsStart": 111.5,
      "contentStart": 111.5,
      "inputLeft": 111.5,
      "barEnd": 911.5,
      "contentEnd": 911.5,
      "overflow": 0
    }
  },
  {
    "name": "vue 1023px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "vue 800px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 29,
      "markPixelsStart": 29,
      "contentStart": 29,
      "inputLeft": 29,
      "barEnd": 771,
      "contentEnd": 771,
      "overflow": 0
    }
  },
  {
    "name": "vue 800px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "vue 390px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 29,
      "markPixelsStart": 29,
      "contentStart": 29,
      "inputLeft": 29,
      "barEnd": 361,
      "contentEnd": 361,
      "overflow": 0
    }
  },
  {
    "name": "vue 390px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "vue 320px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 29,
      "markPixelsStart": 29,
      "contentStart": 29,
      "inputLeft": 29,
      "barEnd": 291,
      "contentEnd": 291,
      "overflow": 0
    }
  },
  {
    "name": "vue 320px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "react 1280px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "20px",
      "brandPad": "10px",
      "contentPad": "20px/20px",
      "brandStart": 240,
      "markPixelsStart": 240,
      "contentStart": 240,
      "inputLeft": 240,
      "barEnd": 1040,
      "contentEnd": 1040,
      "overflow": 0
    }
  },
  {
    "name": "react 1280px: status line pads its items 14px",
    "ok": true,
    "detail": {
      "mode": "14px"
    }
  },
  {
    "name": "react 1024px: tab bar gutter 20px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "20px",
      "brandPad": "10px",
      "contentPad": "20px/20px",
      "brandStart": 112,
      "markPixelsStart": 112,
      "contentStart": 112,
      "inputLeft": 112,
      "barEnd": 912,
      "contentEnd": 912,
      "overflow": 0
    }
  },
  {
    "name": "react 1024px: status line pads its items 14px",
    "ok": true,
    "detail": {
      "mode": "14px"
    }
  },
  {
    "name": "react 1023px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 111.5,
      "markPixelsStart": 111.5,
      "contentStart": 111.5,
      "inputLeft": 111.5,
      "barEnd": 911.5,
      "contentEnd": 911.5,
      "overflow": 0
    }
  },
  {
    "name": "react 1023px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "react 800px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 29,
      "markPixelsStart": 29,
      "contentStart": 29,
      "inputLeft": 29,
      "barEnd": 771,
      "contentEnd": 771,
      "overflow": 0
    }
  },
  {
    "name": "react 800px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "react 390px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 29,
      "markPixelsStart": 29,
      "contentStart": 29,
      "inputLeft": 29,
      "barEnd": 361,
      "contentEnd": 361,
      "overflow": 0
    }
  },
  {
    "name": "react 390px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "react 320px: tab bar gutter 16px, form's edges and first input line up with the brand and the bar's end",
    "ok": true,
    "detail": {
      "barPad": "0px",
      "brandPad": "16px",
      "contentPad": "16px/16px",
      "brandStart": 29,
      "markPixelsStart": 29,
      "contentStart": 29,
      "inputLeft": 29,
      "barEnd": 291,
      "contentEnd": 291,
      "overflow": 0
    }
  },
  {
    "name": "react 320px: status line pads its items 10px",
    "ok": true,
    "detail": {
      "mode": "10px"
    }
  },
  {
    "name": "vue 1280px: First name / Last name share a row",
    "ok": true,
    "detail": {
      "first": {
        "top": 383,
        "left": 240,
        "width": 392
      },
      "last": {
        "top": 383,
        "left": 648,
        "width": 392
      }
    }
  },
  {
    "name": "vue 800px: First name / Last name share a row",
    "ok": true,
    "detail": {
      "first": {
        "top": 348,
        "left": 29,
        "width": 363
      },
      "last": {
        "top": 348,
        "left": 408,
        "width": 363
      }
    }
  },
  {
    "name": "vue 640px: First name / Last name share a row",
    "ok": true,
    "detail": {
      "first": {
        "top": 348,
        "left": 29,
        "width": 283
      },
      "last": {
        "top": 348,
        "left": 328,
        "width": 283
      }
    }
  },
  {
    "name": "vue 639px: First name / Last name stack",
    "ok": true,
    "detail": {
      "first": {
        "top": 348,
        "left": 29,
        "width": 581
      },
      "last": {
        "top": 439,
        "left": 29,
        "width": 581
      }
    }
  },
  {
    "name": "vue 390px: First name / Last name stack",
    "ok": true,
    "detail": {
      "first": {
        "top": 414,
        "left": 29,
        "width": 332
      },
      "last": {
        "top": 505,
        "left": 29,
        "width": 332
      }
    }
  },
  {
    "name": "react 1280px: Postal code/City and Product/Quantity share a row; page columns side by side",
    "ok": true,
    "detail": {
      "zip": {
        "top": 1232,
        "left": 261,
        "width": 125
     

... [1497 bytes truncated] ...

"qty": {
        "top": 620,
        "left": 650,
        "width": 245
      },
      "cols": [
        {
          "top": 246,
          "left": 112
        },
        {
          "top": 1613,
          "left": 112
        }
      ]
    }
  },
  {
    "name": "react 800px: Postal code/City and Product/Quantity share a row; page columns stacked",
    "ok": true,
    "detail": {
      "zip": {
        "top": 1235,
        "left": 46,
        "width": 225
      },
      "city": {
        "top": 1235,
        "left": 287,
        "width": 467
      },
      "product": {
        "top": 620,
        "left": 46,
        "width": 467
      },
      "qty": {
        "top": 620,
        "left": 529,
        "width": 225
      },
      "cols": [
        {
          "top": 246,
          "left": 29
        },
        {
          "top": 1613,
          "left": 29
        }
      ]
    }
  },
  {
    "name": "react 640px: Postal code/City and Product/Quantity share a row; page columns stacked",
    "ok": true,
    "detail": {
      "zip": {
        "top": 1235,
        "left": 46,
        "width": 172
      },
      "city": {
        "top": 1235,
        "left": 234,
        "width": 360
      },
      "product": {
        "top": 620,
        "left": 46,
        "width": 360
      },
      "qty": {
        "top": 620,
        "left": 422,
        "width": 172
      },
      "cols": [
        {
          "top": 246,
          "left": 29
        },
        {
          "top": 1613,
          "left": 29
        }
      ]
    }
  },
  {
    "name": "react 639px: Postal code/City and Product/Quantity stack; page columns stacked",
    "ok": true,
    "detail": {
      "zip": {
        "top": 1326,
        "left": 46,
        "width": 547
      },
      "city": {
        "top": 1417,
        "left": 46,
        "width": 547
      },
      "product": {
        "top": 620,
        "left": 46,
        "width": 547
      },
      "qty": {
        "top": 711,
        "left": 46,
        "width": 547
      },
      "cols": [
        {
          "top": 246,
          "left": 29
        },
        {
          "top": 1795,
          "left": 29
        }
      ]
    }
  },
  {
    "name": "react 390px: Postal code/City and Product/Quantity stack; page columns stacked",
    "ok": true,
    "detail": {
      "zip": {
        "top": 1326,
        "left": 46,
        "width": 298
      },
      "city": {
        "top": 1417,
        "left": 46,
        "width": 298
      },
      "product": {
        "top": 620,
        "left": 46,
        "width": 298
      },
      "qty": {
        "top": 711,
        "left": 46,
        "width": 298
      },
      "cols": [
        {
          "top": 246,
          "left": 29
        },
        {
          "top": 1795,
          "left": 29
        }
      ]
    }
  },
  {
    "name": "vue: --ws-size-icon is 16px, --ws-icon-calendar comes from the design system, local --icon-calendar/--page-gutter gone",
    "ok": true,
    "detail": {
      "sizeIcon": "1rem",
      "calendarDefined": true,
      "oldLocalCalendar": "",
      "oldPageGutter": ""
    }
  },
  {
    "name": "vue: field error icon is 16px wide, masked at 16px",
    "ok": true,
    "detail": {
      "width": "16px",
      "maskSize": "16px auto",
      "maskImage": "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"
    }
  },
  {
    "name": "vue: done step tick is 16px",
    "ok": true,
    "detail": {
      "width": "16px",
      "maskSize": "contain",
      "maskImage": "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"
    }
  },
  {
    "name": "vue: date picker button is 16px, masked with the design system's --ws-icon-calendar",
    "ok": true,
    "detail": {
      "count": 2,
      "width": "16px",
      "height": "16px",
      "maskImage": "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' view",
      "bg": "rgb(87, 82, 121)",
      "allSame": true,
      "sameAsDsToken": true
    }
  },
  {
    "name": "vue: checked box tick is 16px",
    "ok": true,
    "detail": {
      "width": "16px",
      "maskSize": "contain",
      "maskImage": "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"
    }
  },
  {
    "name": "react: field error icon is 16px wide, masked at 16px",
    "ok": true,
    "detail": {
      "width": "16px",
      "maskSize": "16px auto",
      "maskImage": "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"
    }
  },
  {
    "name": "react: checked box tick is 16px",
    "ok": true,
    "detail": {
      "width": "16px",
      "maskSize": "contain",
      "maskImage": "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000"
    }
  },
  {
    "name": "vue 1280px Confirm: 4 summary sections share one value edge, titles take their own row, 24px between sections",
    "ok": true,
    "detail": {
      "sections": [
        "About you",
        "Your visit",
        "Guests",
        "Invoice"
      ],
      "lists": 4,
      "ddLefts": [
        508
      ],
      "dtLefts": [
        240
      ],
      "gapsBetweenSections": [
        24
      ],
      "titlesFullWidth": true,
      "overflow": 0
    }
  },
  {
    "name": "vue 800px Confirm: 4 summary sections share one value edge, titles take their own row, 24px between sections",
    "ok": true,
    "detail": {
      "sections": [
        "About you",
        "Your visit",
        "Guests",
        "Invoice"
      ],
      "lists": 4,
      "ddLefts": [
        297
      ],
      "dtLefts": [
        29
      ],
      "gapsBetweenSections": [
        24
      ],
      "titlesFullWidth": true,
      "overflow": 0
    }
  },
  {
    "name": "vue 390px Confirm: 4 summary sections share one value edge, titles take their own row, 24px between sections",
    "ok": true,
    "detail": {
      "sections": [
        "About you",
        "Your visit",
        "Guests",
        "Invoice"
      ],
      "lists": 4,
      "ddLefts": [
        177.8
      ],
      "dtLefts": [
        29
      ],
      "gapsBetweenSections": [
        24
      ],
      "titlesFullWidth": true,
      "overflow": 0
    }
  },
  {
    "name": "vue: two theme-color tags follow the theme switched by hand (dark #191724, light #faf4ed), no extra tag added",
    "ok": true,
    "detail": {
      "before": [
        "#faf4ed|not all and (prefers-color-scheme: light)",
        "#faf4ed|(prefers-color-scheme: light)"
      ],
      "dark": [
        "#191724|not all and (prefers-color-scheme: light)",
        "#191724|(prefers-color-scheme: light)"
      ],
      "bodyBgDark": "rgb(25, 23, 36)",
      "reloaded": [
        "#191724|not all and (prefers-color-scheme: light)",
        "#191724|(prefers-color-scheme: light)"
      ],
      "light": [
        "#faf4ed|not all and (prefers-color-scheme: light)",
        "#faf4ed|(prefers-color-scheme: light)"
      ]
    }
  },
  {
    "name": "react: two theme-color tags follow the theme switched by hand (dark #191724, light #faf4ed), no extra tag added",
    "ok": true,
    "detail": {
      "before": [
        "#faf4ed|not all and (prefers-color-scheme: light)",
        "#faf4ed|(prefers-color-scheme: light)"
      ],
      "dark": [
        "#191724|not all and (prefers-color-scheme: light)",
        "#191724|(prefers-color-scheme: light)"
      ],
      "bodyBgDark": "rgb(25, 23, 36)",
      "reloaded": [
        "#191724|not all and (prefers-color-scheme: light)",
        "#191724|(prefers-color-scheme: light)"
      ],
      "light": [
        "#faf4ed|not all and (prefers-color-scheme: light)",
        "#faf4ed|(prefers-color-scheme: light)"
      ]
    }
  },
  {
    "name": "vue: with JavaScript off the served page has the dark tag first, then the light one",
    "ok": true,
    "detail": {
      "tags": [
        "#191724|not all and (prefers-color-scheme: light)",
        "#faf4ed|(prefers-color-scheme: light)"
      ]
    }
  },
  {
    "name": "react: with JavaScript off the served page has the dark tag first, then the light one",
    "ok": true,
    "detail": {
      "tags": [
        "#191724|not all and (prefers-color-scheme: light)",
        "#faf4ed|(prefers-color-scheme: light)"
      ]
    }
  }
]
  • Evidence: Browser driver script (local file: ~/.no-mistakes/evidence/01M7J15C9F34ABEX3792CXHWES/drive.cjs)
Evidence: Vue served index.html (theme-color tags as sent)
<!doctype html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Harbour Conf 2027 registration - form-builder sample</title>
    <link rel="icon" href="/favicon.ico" sizes="48x48" />
    <link rel="icon" href="/favicon.svg" type="image/svg+xml" />
    <link rel="apple-touch-icon" href="/apple-touch-icon.png" />
    <meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
    <meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
    <script>(function(){try{var t=localStorage.getItem("ws-theme");if(t==='dark'||t==='light')document.documentElement.dataset.theme=t}catch(e){}})();(function(){var d=document,r=d.documentElement;function p(){var c=getComputedStyle(r).getPropertyValue("--ws-color-bg").trim(),m=d.querySelectorAll("meta[name=\"theme-color\"]");if(!c)return;if(!m.length){m=[d.createElement('meta')];m[0].name='theme-color';d.head.appendChild(m[0])}for(var i=0;i<m.length;i++)m[i].content=c}new MutationObserver(p).observe(r,{attributeFilter:['data-theme','class']});matchMedia('(prefers-color-scheme: light)').addEventListener('change',p);requestAnimationFrame(p);addEventListener('load',p)})()</script>
    <script>(function(){var keys='pending';try{if(localStorage.getItem("ws-keys")==='off')keys='off'}catch(e){}document.documentElement.dataset.wsKeys=keys})()</script>
    <script type="module" crossorigin src="/assets/index-Cllzxj24.js"></script>
    <link rel="stylesheet" crossorigin href="/assets/index-CR9uie1O.css">
  </head>
  <body>
    <div id="app"></div>
  </body>
</html>
Evidence: React served index.html (theme-color tags as sent)
<!doctype html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Checkout - form-builder sample</title>
    <link rel="icon" href="/favicon.ico" sizes="48x48" />
    <link rel="icon" href="/favicon.svg" type="image/svg+xml" />
    <link rel="apple-touch-icon" href="/apple-touch-icon.png" />
    <meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
    <meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
    <script>(function(){try{var t=localStorage.getItem("ws-theme");if(t==='dark'||t==='light')document.documentElement.dataset.theme=t}catch(e){}})();(function(){var d=document,r=d.documentElement;function p(){var c=getComputedStyle(r).getPropertyValue("--ws-color-bg").trim(),m=d.querySelectorAll("meta[name=\"theme-color\"]");if(!c)return;if(!m.length){m=[d.createElement('meta')];m[0].name='theme-color';d.head.appendChild(m[0])}for(var i=0;i<m.length;i++)m[i].content=c}new MutationObserver(p).observe(r,{attributeFilter:['data-theme','class']});matchMedia('(prefers-color-scheme: light)').addEventListener('change',p);requestAnimationFrame(p);addEventListener('load',p)})()</script>
    <script>(function(){var keys='pending';try{if(localStorage.getItem("ws-keys")==='off')keys='off'}catch(e){}document.documentElement.dataset.wsKeys=keys})()</script>
    <script type="module" crossorigin src="/assets/index-BoDxgmmZ.js"></script>
    <link rel="stylesheet" crossorigin href="/assets/index-C6urBOmG.css">
  </head>
  <body>
    <div id="root"></div>
  </body>
</html>
Evidence: Served <head> theme-color tags (both apps)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>themeInitScript</script>
<script>keysInitScript</script>
<script type=module ...> <link rel=stylesheet ...>

Vue Confirm step, 1280px dark: 4 sections share one value column

Vue Confirm summary at 390px

Vue Confirm summary at 800px

Vue date row with design-system calendar icons

Vue Your visit step, 1280px

Vue first view, 390px (16px gutter)

Vue first view, 1280px

Vue 800px: name fields share a row

Vue 639px: name fields stack

React 800px: field rows side by side, page columns stacked

React 639px: field rows stacked

React 390px with errors and checked tick (16px icons)

React first view, 390px

React first view, 1280px

  • Evidence: Vue targeted e2e transcript (19 passed, 1 skipped) (local file: ~/.no-mistakes/evidence/01M7J15C9F34ABEX3792CXHWES/vue-e2e-transcript.txt)
  • Evidence: React targeted e2e transcript (31 passed, 1 skipped) (local file: ~/.no-mistakes/evidence/01M7J15C9F34ABEX3792CXHWES/react-e2e-transcript.txt)

Pipeline

Updates from git push no-mistakes

✅ **Intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

  • Live validation: ✅ go - 10 of 10 scenarios driven live against the product
Scenario Result Live Evidence
Both apps install and build on @whatsaaaa/design-system 0.8.0 from the committed lockfile ✅ pass live pnpm install --frozen-lockfile then pnpm build succeeded in both apps; node_modules/@whatsaaaa/design-system/package.json reports 0.8.0
Served page (vite preview :4273 / Node server :4274) carries the two theme-color tags from themeColorMeta, dark #191724 first, then light #faf4ed, before the head scripts, including with JavaScript of… ✅ pass live vue-served-index.html, react-served-index.html; drive-transcript.txt 'with JavaScript off the served page has the dark tag first, then the light one' (both apps)
Switching the theme by hand in the status line updates both theme-color tags to the theme shown, survives a reload, and adds no extra tag (both apps) ✅ pass live drive-transcript.txt 'two theme-color tags follow the theme switched by hand' for vue and react; frame.spec 'switches the theme, and remembers it' passed in both e2e transcripts
Form content and first input line up with the tab bar's brand and end: 20px gutter at 1280/1024px, the design system's 16px phone gutter at 1023/800/390/320px, no sideways scroll (both apps) ✅ pass live drive-transcript.txt gutter checks (12 PASS); vue-390-first-view.png, react-390-first-view.png, *-1280-first-view.png
Rows of fields share a line from 40rem (640px) up and stack below (639px, 390px); React's page columns still stack below 64rem (1023px) and sit side by side at 1024px+ ✅ pass live drive-transcript.txt row checks (12 PASS); vue-800-row.png, vue-639-row.png, react-800-rows.png, react-639-rows.png
Vue date picker button draws the design system's --ws-icon-calendar at 16px (local --icon-calendar removed) ✅ pass live drive-transcript.txt 'date picker button is 16px, masked with the design system's --ws-icon-calendar' (2 indicators, mask equals the DS token); vue-date-row-calendar-icons.png
Icons next to text draw at --ws-size-icon (16px): field error icons, checkbox ticks, Vue done-step ticks (radio dots stay 8px) ✅ pass live drive-transcript.txt icon checks (vue error/done tick/checkbox, react error/checkbox); react-390-errors-and-icons.png, vue-1280-confirm-full-window-dark.png (done-step ticks)
Vue Confirm step: all 4 review sections (About you, Your visit, Guests, Invoice) share one term column, so every value starts at one x; titles take their own row; 24px between sections; no overflow at… ✅ pass live drive-transcript.txt Confirm checks (single dd left per width: 508/297/177.8); vue-1280-confirm-full-window-dark.png, vue-800-confirm-summary.png, vue-390-confirm-summary.png; registration fit e2e pas…
Status line pads its items 14px from 64rem up and 10px below, and stays whole from 320 to 400px with keys on and off (both apps) ✅ pass live drive-transcript.txt status line padding checks (12 PASS); frame.spec 'keeps the status line whole on a narrow screen' passed in both e2e transcripts
Existing end-to-end flows still work on 0.8.0: Vue registration happy path and fit-the-screen at 320/390px; React order placement, fit-the-screen in EN/DE, forced-colors states ✅ pass live vue-e2e-transcript.txt (19 passed, 1 skipped), react-e2e-transcript.txt (31 passed, 1 skipped)
  • pnpm install --frozen-lockfile in react-checkout and vue-event-registration (design-system 0.8.0 resolved)
  • pnpm build in both apps, then vite preview --port 4273 (Vue) and PORT=4274 pnpm start (React)
  • curl -s http://localhost:4273/ and curl -s http://localhost:4274/: inspected the served <head> for the theme-color tags and their order
  • node drive.cjs &lt;react-checkout&gt; (evidence dir): 50 live Chromium checks covering gutter, rows, icons, calendar, summary alignment, status line and theme-color, plus screenshots
  • node confirm-desktop.cjs &lt;react-checkout&gt;: full-window Confirm step capture at 1280px
  • pnpm exec playwright test e2e/frame.spec.ts e2e/registration.spec.ts -g &#34;frame|status line|theme|keys|fits the screen|registers a business attendee&#34; in vue-event-registration: 19 passed, 1 skipped
  • pnpm exec playwright test e2e/frame.spec.ts e2e/checkout.spec.ts -g &#34;frame|status line|theme|keys|fits the screen|places an order|ticked box&#34; in react-checkout: 31 passed, 1 skipped
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

@whatsaaaa
whatsaaaa merged commit 71a7556 into main Nov 16, 2026
2 checks passed
@whatsaaaa
whatsaaaa deleted the fm/samples-ds-080 branch November 16, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant