Repository navigation
fix: move sample apps to design-system 0.8.0 and drop covered workarounds - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Move the Vue and React sample apps to design system 0.8.0, which closes the gaps found when they adopted 0.6.1 in #6 (whatsaaaa/design-system#23), and drop the local workarounds the release now covers, following its migration notes.
What Changed
react-checkoutandvue-event-registrationfrom@whatsaaaa/design-system^0.6.1to^0.8.0(package.json, lockfiles,minimumReleaseAgeExclude). Both apps' Vite head plugins now also add the package'sthemeColorMetatheme-color tags ahead of the theme and keys init scripts.--page-guttervariable is gone and its 20px and 16px values (--ws-space-20/--ws-space-16) are set directly, with the 16px phone gutter applied below 64rem. Icon sizes use--ws-size-iconinstead of--ws-space-16/1rem, and the Vue date picker uses--ws-icon-calendarinstead of its own inline SVG--icon-calendar..row--sectionscolumns still stack below 64rem. The Vue review summary (SummaryList.vue) is now a singlews-pairs-groupwith no per-section<section>wrappers, so values in every section line up. The spacing between sections now comes from a top margin on each section title.🤖 Generated with Claude Code
Workarounds, one by one
Removed in both apps unless noted:
--page-gutteris gone. The content is padded--ws-space-20from 64rem and--ws-space-16, the phone gutter the usage guide names, below it. Neither app had a pane padded 20px below 64rem (groups were already 16px), so nothing moved.--ws-size-icon.--ws-icon-calendarreplaces the app's own.40rem, not 64rem. React's page columns (row--sections) still stack below 64rem, since a page has one column there.ws-pairs--amountslist): the Confirm lists are in onews-pairs-group. The<section>wrappers are gone because the group needs the headings and lists as its children. The 24px between sections is now the title's top margin.themeColorMeta, as the usage guide's plugin does.Kept:
minimumReleaseAgeExcludekeeps an entry for@whatsaaaa/design-system@0.8.0(in place of 0.6.1): pnpm 11 refuses the release without it, as it was published on 2026-11-15.--ws-space-8: a dot, not an icon, and the system has no token for it.--ws-space-20: a 20px icon, deliberately larger than the 16px icon size.Design-system gaps still open: none found.
Visible changes
I screenshotted both apps on
mainand on this branch, in both themes, at 320, 390, 768 and 1440px, including a date field and the Vue Confirm step, and pixel-diffed them. Each change that shows is one the 0.8.0 notes intend:Everything else is pixel-identical. The only other differences are a few anti-aliased pixels on radio and input edges, which also differ between two runs of
main. The built HTML as sent (fetched without JavaScript) carries both theme-color tags in both apps,#191724for dark first and#faf4edfor a light system. In the browser there are exactly two, and they follow the theme switch.Risk Assessment
✅ Low: A narrow dependency bump with CSS and head-tag migrations that match the published design-system 0.8.0 usage docs one for one, and the visible behavior is unchanged except for what the intent asks for: rows now stack below 40rem, the review sections share one term column, and theme-color tags are sent with the page.
Testing
I built both apps for production and served them the way users run them: Vue on vite preview :4273, React on its own Node server :4274. A Chromium script made 50 live checks at widths from 320px to 1280px, all passing, with screenshots, and it tested the boundaries on both sides: 1023/1024px for 64rem and 639/640px for 40rem. The checks covered: theme-color tags as sent and with JavaScript off; theme-color following a manual theme switch and a reload with no extra tag added; the gutter lining up with the brand and the bar's end; rows sharing a line or stacking at each breakpoint; React's page columns; icon sizes and the calendar mask (read over CDP from the date input's shadow tree); Confirm-section alignment with 4 sections; and status line padding. The existing Playwright frame, fit-the-screen, happy-path and forced-colors specs also passed against the same servers on both desktop and mobile: Vue 19 passed and React 31 passed, each with 1 skipped by design (the
t-key test is desktop-only). The servers are stopped, and dist/ and the test outputs are removed.pnpm install --frozen-lockfilethenpnpm buildsucceeded in both apps; node_modules/@whatsaaaa/design-system/package.json reports 0.8.0Evidence: Live check transcript (50/50 pass)
Evidence: Live check results with measurements
~/.no-mistakes/evidence/01M7J15C9F34ABEX3792CXHWES/drive.cjs)Evidence: Vue served index.html (theme-color tags as sent)
Evidence: React served index.html (theme-color tags as sent)
Evidence: Served <head> theme-color tags (both apps)
~/.no-mistakes/evidence/01M7J15C9F34ABEX3792CXHWES/vue-e2e-transcript.txt)~/.no-mistakes/evidence/01M7J15C9F34ABEX3792CXHWES/react-e2e-transcript.txt)Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
pnpm install --frozen-lockfilethenpnpm buildsucceeded in both apps; node_modules/@whatsaaaa/design-system/package.json reports 0.8.0pnpm install --frozen-lockfilein react-checkout and vue-event-registration (design-system 0.8.0 resolved)pnpm buildin both apps, thenvite preview --port 4273(Vue) andPORT=4274 pnpm start(React)curl -s http://localhost:4273/andcurl -s http://localhost:4274/: inspected the served <head> for the theme-color tags and their ordernode drive.cjs <react-checkout>(evidence dir): 50 live Chromium checks covering gutter, rows, icons, calendar, summary alignment, status line and theme-color, plus screenshotsnode confirm-desktop.cjs <react-checkout>: full-window Confirm step capture at 1280pxpnpm exec playwright test e2e/frame.spec.ts e2e/registration.spec.ts -g "frame|status line|theme|keys|fits the screen|registers a business attendee"in vue-event-registration: 19 passed, 1 skippedpnpm exec playwright test e2e/frame.spec.ts e2e/checkout.spec.ts -g "frame|status line|theme|keys|fits the screen|places an order|ticked box"in react-checkout: 31 passed, 1 skipped✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.