Skip to content

fix: move both sample apps to design-system 0.8.1 - #8

Merged
whatsaaaa merged 1 commit into
mainfrom
fm/samples-ds-081
Nov 16, 2026
Merged

whatsaaaa merged 1 commit into
mainfrom
fm/samples-ds-081

Conversation

@whatsaaaa

@whatsaaaa whatsaaaa commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Intent

Move the Vue and React sample apps to design system 0.8.1 (whatsaaaa/design-system#25), which hides the status line's path where it showed a one-letter stub and cuts it at five characters otherwise.

What Changed

  • Bumps @whatsaaaa/design-system from ^0.8.0 to ^0.8.1 in react-checkout and vue-event-registration. Both package.json files and lockfiles are updated, and each app's minimumReleaseAgeExclude entry in pnpm-workspace.yaml now names 0.8.1 instead of 0.8.0.
  • Raises the bar in the status line e2e checks (react-checkout/e2e/checks.ts, vue-event-registration/e2e/frame.spec.ts) to match 0.8.1. When the path shows, its text box must now fit five characters plus an ellipsis (xxxxx…), not just ~…. When the path is hidden, there must not be room for those five characters and the ellipsis. The doc comments and assertion messages are updated to match.

🤖 Generated with Claude Code

Risk Assessment

✅ Low: The change only bumps the design system from 0.8.0 to 0.8.1, a CSS and docs-only patch whose package.json differs from 0.8.0 only in its version, and the e2e path probe now matches the new 6ch threshold.

Testing

I installed both apps from their lockfiles (design-system 0.8.1) and ran each app's existing frame e2e spec against its production build, on desktop and Pixel 7. Both passed: Vue 9 passed with 1 skipped, React 21 passed with 1 skipped, and both include the 320-400px status-line sweep. As an independent check, I drove both running apps at every width from 300 to 1100px, in both themes and with the keys on or off, counting the characters actually drawn before the ellipsis. Every width either hid the path as a whole, showed it whole, or cut it after 5 or more characters, with no sideways overflow. I took status-line screenshots at 320, 360, 390, 412, 1024 and 1280px, plus the widths just before and after the path first shows. For before/after, I temporarily put 0.8.0 into the Vue app. It reproduced the ~… stub at 320px in the light theme, and the updated e2e assertion failed on it. Then I restored the committed 0.8.1 files. The docs-theme .logo part could not be exercised because neither app uses the docs theme. I removed all build, test and dependency outputs from the worktree and stopped every server.

  • Live validation: ✅ go - 6 of 7 scenarios driven live against the product
Scenario Result Live Evidence
A developer installs each sample app from its committed lockfile and gets design-system 0.8.1, and the production build succeeds ✅ pass live pnpm install --frozen-lockfile exited 0 in both apps, and node_modules/@whatsaaaa/design-system/package.json reads 0.8.1. The Playwright webServer ran vue-tsc -b && vite build and `tsc -b && vite…
Vue app (vite preview of the production build): the status line stays whole while the theme and keys switches work, on desktop and Pixel 7 (existing frame e2e) ✅ pass live vue-frame-e2e.log: 9 passed, 1 skipped (the t-key test is desktop-only by design), including the 320-400px 'keeps the status line whole on a narrow screen' sweeps in both themes
React app (pnpm start, the production server with its API): the status line stays whole, the switches and forced-colors checks pass, on desktop and Pixel 7 (existing frame e2e) ✅ pass live react-frame-e2e.log: 21 passed, 1 skipped (desktop-only test)
On a phone width (320px) and every width from 300 to 1100px, keys on or off, the status-line path in both apps is never a 1-4 character stub: it is hidden as a whole, shown whole, or cut with an ellip… ✅ pass live status-line-sweep.log (dark) and after-0.8.1-light-status-line-sweep.log (light): fewest characters drawn when cut = 5 for both apps, 0 failures over 1,602 widths per app per theme, no line overflow.…
Adversarial before/after: with design-system 0.8.0 the Vue app shows a ~… stub at 320px, and the updated e2e assertion catches it; with 0.8.1 the stub is gone ✅ pass live before-0.8.0-light-vue-keys-on-320px-status-line.png shows ~…. before-0.8.0-light-status-line-sweep.log: 'fewest chars drawn when cut: 1', 57 failing widths. before-0.8.0-vue-frame-narrow-e2e.log: l…
On desktop widths (1024px and up) both apps show the full path (~/vue-event-registration, ~/react-checkout) in the status line ✅ pass live Sweep logs report 'whole' at 1024 and 1280px for both apps in both themes. Screenshots: react-keys-on-1280px-status-line.png, vue-keys-on-1280px-status-line.png, after-0.8.1-light-*-1024px-status-line…
Docs-theme brand mark: a site on the docs theme gets the edge-aligned logo with no margin of its own on .logo ⏸️ untested no Neither sample app uses the design system's VitePress docs theme or defines a .logo rule, so this repository has no docs-theme surface to drive. That part of 0.8.1 applies to docs sites, not to thes…

Before (0.8.0): Vue status line at 320px, light theme, shows the one-character ~… stub

After (0.8.1): Vue status line at 320px, light theme, path hidden as a whole

After (0.8.1): Vue status line at 348px, light theme, first width the path shows: ~/vue… (5 chars)

After (0.8.1): React status line at 355px, keys off, light theme: ~/rea… (5 chars)

After (0.8.1): Vue status line at 320px, keys off, dark theme: ~/vue…

After (0.8.1): React status line at 312px, dark theme: ~/rea…

After (0.8.1): React status line at 1280px, path whole

Evidence: Light-theme sweep on 0.8.1, both apps (SWEEP PASS)

vue: 1602 widths, hidden at 103, cut at 258 (fewest chars drawn when cut: 5), whole at 1241, failures 0 react: 1602 widths, hidden at 103, cut at 142 (fewest chars drawn when cut: 5), whole at 1357, failures 0 SWEEP PASS

vue keys=on 320px: path hidden -> after-0.8.1-light-vue-keys-on-320px-status-line.png
vue keys=on 347px: path hidden -> after-0.8.1-light-vue-keys-on-347px-status-line.png
vue keys=on 348px: cut -> "~/vue…" (5 chars) -> after-0.8.1-light-vue-keys-on-348px-status-line.png
vue keys=on 360px: cut -> "~/vue-…" (6 chars) -> after-0.8.1-light-vue-keys-on-360px-status-line.png
vue keys=on 390px: cut -> "~/vue-even…" (10 chars) -> after-0.8.1-light-vue-keys-on-390px-status-line.png
vue keys=on 412px: cut -> "~/vue-event-re…" (14 chars) -> after-0.8.1-light-vue-keys-on-412px-status-line.png
vue keys=on 1024px: whole "~/vue-event-registration" -> after-0.8.1-light-vue-keys-on-1024px-status-line.png
vue keys=on 1280px: whole "~/vue-event-registration" -> after-0.8.1-light-vue-keys-on-1280px-status-line.png
vue keys=on: path first shows at 348px with "~/vue"
vue keys=off 320px: path hidden -> after-0.8.1-light-vue-keys-off-320px-status-line.png
vue keys=off 354px: path hidden -> after-0.8.1-light-vue-keys-off-354px-status-line.png
vue keys=off 355px: cut -> "~/vue…" (5 chars) -> after-0.8.1-light-vue-keys-off-355px-status-line.png
vue keys=off 360px: cut -> "~/vue…" (5 chars) -> after-0.8.1-light-vue-keys-off-360px-status-line.png
vue keys=off 390px: cut -> "~/vue-eve…" (9 chars) -> after-0.8.1-light-vue-keys-off-390px-status-line.png
vue keys=off 412px: cut -> "~/vue-event-r…" (13 chars) -> after-0.8.1-light-vue-keys-off-412px-status-line.png
vue keys=off 1024px: whole "~/vue-event-registration" -> after-0.8.1-light-vue-keys-off-1024px-status-line.png
vue keys=off 1280px: whole "~/vue-event-registration" -> after-0.8.1-light-vue-keys-off-1280px-status-line.png
vue keys=off: path first shows at 355px with "~/vue"
vue: 1602 widths, hidden at 103, cut at 258 (fewest chars drawn when cut: 5), whole at 1241, failures 0
react keys=on 320px: path hidden -> after-0.8.1-light-react-keys-on-320px-status-line.png
react keys=on 347px: path hidden -> after-0.8.1-light-react-keys-on-347px-status-line.png
react keys=on 348px: cut -> "~/rea…" (5 chars) -> after-0.8.1-light-react-keys-on-348px-status-line.png
react keys=on 360px: cut -> "~/reac…" (6 chars) -> after-0.8.1-light-react-keys-on-360px-status-line.png
react keys=on 390px: cut -> "~/react-ch…" (10 chars) -> after-0.8.1-light-react-keys-on-390px-status-line.png
react keys=on 412px: cut -> "~/react-checko…" (14 chars) -> after-0.8.1-light-react-keys-on-412px-status-line.png
react keys=on 1024px: whole "~/react-checkout" -> after-0.8.1-light-react-keys-on-1024px-status-line.png
react keys=on 1280px: whole "~/react-checkout" -> after-0.8.1-light-react-keys-on-1280px-status-line.png
react keys=on: path first shows at 348px with "~/rea"
react keys=off 320px: path hidden -> after-0.8.1-light-react-keys-off-320px-status-line.png
react keys=off 354px: path hidden -> after-0.8.1-light-react-keys-off-354px-status-line.png
react keys=off 355px: cut -> "~/rea…" (5 chars) -> after-0.8.1-light-react-keys-off-355px-status-line.png
react keys=off 360px: cut -> "~/rea…" (5 chars) -> after-0.8.1-light-react-keys-off-360px-status-line.png
react keys=off 390px: cut -> "~/react-c…" (9 chars) -> after-0.8.1-light-react-keys-off-390px-status-line.png
react keys=off 412px: cut -> "~/react-check…" (13 chars) -> after-0.8.1-light-react-keys-off-412px-status-line.png
react keys=off 1024px: whole "~/react-checkout" -> after-0.8.1-light-react-keys-off-1024px-status-line.png
react keys=off 1280px: whole "~/react-checkout" -> after-0.8.1-light-react-keys-off-1280px-status-line.png
react keys=off: path first shows at 355px with "~/rea"
react: 1602 widths, hidden at 103, cut at 142 (fewest chars drawn when cut: 5), whole at 1357, failures 0
SWEEP PASS
Evidence: Dark-theme sweep on 0.8.1, both apps (SWEEP PASS)
vue keys=on 312px: cut -> "~/vue…" (5 chars) -> vue-keys-on-312px-status-line.png
vue keys=on 320px: cut -> "~/vue-…" (6 chars) -> vue-keys-on-320px-status-line.png
vue keys=on 360px: cut -> "~/vue-event…" (11 chars) -> vue-keys-on-360px-status-line.png
vue keys=on 390px: cut -> "~/vue-event-reg…" (15 chars) -> vue-keys-on-390px-status-line.png
vue keys=on 412px: cut -> "~/vue-event-registr…" (19 chars) -> vue-keys-on-412px-status-line.png
vue keys=on 1024px: whole "~/vue-event-registration" -> vue-keys-on-1024px-status-line.png
vue keys=on 1280px: whole "~/vue-event-registration" -> vue-keys-on-1280px-status-line.png
vue keys=on: path first shows at 312px with "~/vue"
vue keys=off 319px: cut -> "~/vue…" (5 chars) -> vue-keys-off-319px-status-line.png
vue keys=off 320px: cut -> "~/vue…" (5 chars) -> vue-keys-off-320px-status-line.png
vue keys=off 360px: cut -> "~/vue-even…" (10 chars) -> vue-keys-off-360px-status-line.png
vue keys=off 390px: cut -> "~/vue-event-re…" (14 chars) -> vue-keys-off-390px-status-line.png
vue keys=off 412px: cut -> "~/vue-event-regist…" (18 chars) -> vue-keys-off-412px-status-line.png
vue keys=off 1024px: whole "~/vue-event-registration" -> vue-keys-off-1024px-status-line.png
vue keys=off 1280px: whole "~/vue-event-registration" -> vue-keys-off-1280px-status-line.png
vue keys=off: path first shows at 319px with "~/vue"
vue: 1602 widths, hidden at 31, cut at 258 (fewest chars drawn when cut: 5), whole at 1313, failures 0
react keys=on 312px: cut -> "~/rea…" (5 chars) -> react-keys-on-312px-status-line.png
react keys=on 320px: cut -> "~/reac…" (6 chars) -> react-keys-on-320px-status-line.png
react keys=on 360px: cut -> "~/react-che…" (11 chars) -> react-keys-on-360px-status-line.png
react keys=on 390px: whole "~/react-checkout" -> react-keys-on-390px-status-line.png
react keys=on 412px: whole "~/react-checkout" -> react-keys-on-412px-status-line.png
react keys=on 1024px: whole "~/react-checkout" -> react-keys-on-1024px-status-line.png
react keys=on 1280px: whole "~/react-checkout" -> react-keys-on-1280px-status-line.png
react keys=on: path first shows at 312px with "~/rea"
react keys=off 319px: cut -> "~/rea…" (5 chars) -> react-keys-off-319px-status-line.png
react keys=off 320px: cut -> "~/rea…" (5 chars) -> react-keys-off-320px-status-line.png
react keys=off 360px: cut -> "~/react-ch…" (10 chars) -> react-keys-off-360px-status-line.png
react keys=off 390px: whole "~/react-checkout" -> react-keys-off-390px-status-line.png
react keys=off 412px: whole "~/react-checkout" -> react-keys-off-412px-status-line.png
react keys=off 1024px: whole "~/react-checkout" -> react-keys-off-1024px-status-line.png
react keys=off 1280px: whole "~/react-checkout" -> react-keys-off-1280px-status-line.png
react keys=off: path first shows at 319px with "~/rea"
react: 1602 widths, hidden at 31, cut at 142 (fewest chars drawn when cut: 5), whole at 1429, failures 0
SWEEP PASS
Evidence: Light-theme sweep on 0.8.0, Vue (reproduces the stub, SWEEP FAIL)

vue keys=on 319px: cut -> "…" (1 chars) vue keys=on 320px: cut -> "…" (1 chars) vue: 1602 widths, ... (fewest chars drawn when cut: 1), failures 57 SWEEP FAIL: 57 widths broke the contract

vue keys=on 318px: path hidden -> before-0.8.0-light-vue-keys-on-318px-status-line.png
vue keys=on 319px: cut -> "~…" (1 chars) -> before-0.8.0-light-vue-keys-on-319px-status-line.png
vue keys=on 320px: cut -> "~…" (1 chars) -> before-0.8.0-light-vue-keys-on-320px-status-line.png
vue keys=on 360px: cut -> "~/vue-…" (6 chars) -> before-0.8.0-light-vue-keys-on-360px-status-line.png
vue keys=on 390px: cut -> "~/vue-even…" (10 chars) -> before-0.8.0-light-vue-keys-on-390px-status-line.png
vue keys=on 412px: cut -> "~/vue-event-re…" (14 chars) -> before-0.8.0-light-vue-keys-on-412px-status-line.png
vue keys=on 1024px: whole "~/vue-event-registration" -> before-0.8.0-light-vue-keys-on-1024px-status-line.png
vue keys=on 1280px: whole "~/vue-event-registration" -> before-0.8.0-light-vue-keys-on-1280px-status-line.png
vue keys=on: path first shows at 319px with "~"
vue keys=off 320px: path hidden -> before-0.8.0-light-vue-keys-off-320px-status-line.png
vue keys=off 325px: path hidden -> before-0.8.0-light-vue-keys-off-325px-status-line.png
vue keys=off 326px: cut -> "~…" (1 chars) -> before-0.8.0-light-vue-keys-off-326px-status-line.png
vue keys=off 360px: cut -> "~/vue…" (5 chars) -> before-0.8.0-light-vue-keys-off-360px-status-line.png
vue keys=off 390px: cut -> "~/vue-eve…" (9 chars) -> before-0.8.0-light-vue-keys-off-390px-status-line.png
vue keys=off 412px: cut -> "~/vue-event-r…" (13 chars) -> before-0.8.0-light-vue-keys-off-412px-status-line.png
vue keys=off 1024px: whole "~/vue-event-registration" -> before-0.8.0-light-vue-keys-off-1024px-status-line.png
vue keys=off 1280px: whole "~/vue-event-registration" -> before-0.8.0-light-vue-keys-off-1280px-status-line.png
vue keys=off: path first shows at 326px with "~"
vue: 1602 widths, hidden at 45, cut at 316 (fewest chars drawn when cut: 1), whole at 1241, failures 57
SWEEP FAIL: 57 widths broke the contract
Evidence: Updated Vue narrow-screen e2e fails on 0.8.0 (light theme)

✘ [desktop] in the light theme › keeps the status line whole on a narrow screen Error: the path shows less than five characters Expected: >= 43.203125 Received: 15.875

[WebServer] $ vue-tsc -b && vite build

Running 2 tests using 2 workers

  ✘  1 [desktop] › e2e/frame.spec.ts:187:5 › in the light theme › keeps the status line whole on a narrow screen (1.1s)
  ✓  2 [desktop] › e2e/frame.spec.ts:187:5 › in the dark theme › keeps the status line whole on a narrow screen (3.4s)


  1) [desktop] › e2e/frame.spec.ts:187:5 › in the light theme › keeps the status line whole on a narrow screen 

    Error: the path shows less than five characters

    expect(received).toBeGreaterThanOrEqual(expected)

    Expected: >= 43.203125
    Received:    15.875

      63 |       line.text,
      64 |       'the path shows less than five characters',
    > 65 |     ).toBeGreaterThanOrEqual(line.shortest)
         |       ^
      66 |     expect(
      67 |       line.after,
      68 |       'the path runs into the keys switch',
        at expectStatusLineWhole ({run-worktree}/vue-event-registration/e2e/frame.spec.ts:65:7)
        at {run-worktree}/vue-event-registration/e2e/frame.spec.ts:199:15

    Error Context: test-results/frame-in-the-light-theme-k-b5e4b-ne-whole-on-a-narrow-screen-desktop/error-context.md

    attachment #2: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/frame-in-the-light-theme-k-b5e4b-ne-whole-on-a-narrow-screen-desktop/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/frame-in-the-light-theme-k-b5e4b-ne-whole-on-a-narrow-screen-desktop/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [desktop] › e2e/frame.spec.ts:187:5 › in the light theme › keeps the status line whole on a narrow screen 
  1 passed (17.0s)
Evidence: Vue frame e2e on 0.8.1 (9 passed, 1 skipped)
[WebServer] $ vue-tsc -b && vite build

Running 10 tests using 4 workers

  ✓   2 [desktop] › e2e/frame.spec.ts:147:3 › on a dark system › switches the theme with the t key while the keys are on (3.0s)
  ✓   1 [desktop] › e2e/frame.spec.ts:118:1 › switches the shortcut keys off and on, and remembers it (3.4s)
  ✓   4 [desktop] › e2e/frame.spec.ts:91:3 › on a light system › switches the theme, and remembers it (3.5s)
  ✓   3 [desktop] › e2e/frame.spec.ts:187:5 › in the dark theme › keeps the status line whole on a narrow screen (7.6s)
  ✓   5 [desktop] › e2e/frame.spec.ts:187:5 › in the light theme › keeps the status line whole on a narrow screen (7.0s)
  ✓   6 [mobile] › e2e/frame.spec.ts:91:3 › on a light system › switches the theme, and remembers it (3.7s)
  ✓   7 [mobile] › e2e/frame.spec.ts:118:1 › switches the shortcut keys off and on, and remembers it (3.4s)
  -   9 [mobile] › e2e/frame.spec.ts:147:3 › on a dark system › switches the theme with the t key while the keys are on
  ✓   8 [mobile] › e2e/frame.spec.ts:187:5 › in the light theme › keeps the status line whole on a narrow screen (6.3s)
  ✓  10 [mobile] › e2e/frame.spec.ts:187:5 › in the dark theme › keeps the status line whole on a narrow screen (5.9s)

  1 skipped
  9 passed (37.0s)
Evidence: React frame e2e on 0.8.1 (21 passed, 1 skipped)
[WebServer] $ tsc -b && vite build
[WebServer] $ tsx server/index.ts dist

Running 22 tests using 4 workers

  ✓   3 [desktop] › e2e/frame.spec.ts:85:3 › on a dark system › switches the theme with the t key while the keys are on (3.9s)
  ✓   1 [desktop] › e2e/frame.spec.ts:29:3 › on a light system › switches the theme, and remembers it (4.3s)
  ✓   4 [desktop] › e2e/frame.spec.ts:56:1 › switches the shortcut keys off and on, and remembers it (4.1s)
  ✓   6 [desktop] › e2e/frame.spec.ts:190:5 › in forced colors, on a light system › tells the pressed language and a ticked box from the others (2.7s)
  ✓   7 [desktop] › e2e/frame.spec.ts:220:5 › in forced colors, on a light system › shows the name of each language, pressed or not (3.8s)
  ✓   8 [desktop] › e2e/frame.spec.ts:238:5 › in forced colors, on a light system › rings the pressed language in focus as it rings the other (3.1s)
  ✓   9 [desktop] › e2e/frame.spec.ts:190:5 › in forced colors, on a dark system › tells the pressed language and a ticked box from the others (3.0s)
  ✓   2 [desktop] › e2e/frame.spec.ts:125:5 › in the dark theme › keeps the status line whole on a narrow screen (11.4s)
  ✓  10 [desktop] › e2e/frame.spec.ts:220:5 › in forced colors, on a dark system › shows the name of each language, pressed or not (3.1s)
  ✓  11 [desktop] › e2e/frame.spec.ts:238:5 › in forced colors, on a dark system › rings the pressed language in focus as it rings the other (2.2s)
  ✓   5 [desktop] › e2e/frame.spec.ts:125:5 › in the light theme › keeps the status line whole on a narrow screen (10.2s)
  ✓  12 [mobile] › e2e/frame.spec.ts:29:3 › on a light system › switches the theme, and remembers it (3.8s)
  -  14 [mobile] › e2e/frame.spec.ts:85:3 › on a dark system › switches the theme with the t key while the keys are on
  ✓  13 [mobile] › e2e/frame.spec.ts:56:1 › switches the shortcut keys off and on, and remembers it (4.1s)
  ✓  17 [mobile] › e2e/frame.spec.ts:190:5 › in forced colors, on a light system › tells the pressed language and a ticked box from the others (2.9s)
  ✓  18 [mobile] › e2e/frame.spec.ts:220:5 › in forced colors, on a light system › shows the name of each language, pressed or not (3.7s)
  ✓  19 [mobile] › e2e/frame.spec.ts:238:5 › in forced colors, on a light system › rings the pressed language in focus as it rings the other (2.0s)
  ✓  20 [mobile] › e2e/frame.spec.ts:190:5 › in forced colors, on a dark system › tells the pressed language and a ticked box from the others (2.0s)
  ✓  21 [mobile] › e2e/frame.spec.ts:220:5 › in forced colors, on a dark system › shows the name of each language, pressed or not (2.3s)
  ✓  15 [mobile] › e2e/frame.spec.ts:125:5 › in the dark theme › keeps the status line whole on a narrow screen (9.6s)
  ✓  22 [mobile] › e2e/frame.spec.ts:238:5 › in forced colors, on a dark system › rings the pressed language in focus as it rings the other (1.6s)
  ✓  16 [mobile] › e2e/frame.spec.ts:125:5 › in the light theme › keeps the status line whole on a narrow screen (9.2s)

  1 skipped
  21 passed (46.1s)
Evidence: Published CSS diff, design-system 0.8.0 -> 0.8.1
--- a/package/dist/css/terminal.css	1985-10-26 09:15:00
+++ b/package/dist/css/terminal.css	1985-10-26 09:15:00
@@ -405,9 +405,9 @@
 
 /*
  * The room the other items leave, which the path takes: the items after it go to the right
- * edge, as after a spacer. The path gives way to them inside it. It shrinks to its first
- * character and the ellipsis, then goes as a whole, padding and all, so a part of a
- * character never shows.
+ * edge, as after a spacer. The path gives way to them inside it. It is cut with an ellipsis
+ * down to five characters, then goes as a whole, padding and all: a letter or two before
+ * the ellipsis reads as a glitch, not a path.
  */
 .ws-status-line__path {
   flex: 1;
@@ -429,12 +429,13 @@
 }
 
 /*
- * No room for "~…" between the padding of the path, --ws-space-14 on each side, and
- * --ws-space-10 below 64rem. The padding is written out, as a container query takes no var().
- * The browser test of the path, tests/browser/status-line.spec.ts, holds them together.
+ * No room for five characters and the ellipsis, 6ch of the caption's mono face, between the
+ * padding of the path, --ws-space-14 on each side, and --ws-space-10 below 64rem. The padding
+ * is written out, as a container query takes no var(). The browser test of the path,
+ * tests/browser/status-line.spec.ts, holds them together.
  */
 @media (width >= 64rem) {
-  @container ws-status-line-path (width < calc(2ch + 1.75rem)) {
+  @container ws-status-line-path (width < calc(6ch + 1.75rem)) {
     .ws-status-line__file {
       display: none;
     }
@@ -442,7 +443,7 @@
 }
 
 @media (width < 64rem) {
-  @container ws-status-line-path (width < calc(2ch + 1.25rem)) {
+  @container ws-status-line-path (width < calc(6ch + 1.25rem)) {
     .ws-status-line__file {
       display: none;
     }
--- a/package/src/vitepress/styles/nav.css	1985-10-26 09:15:00
+++ b/package/src/vitepress/styles/nav.css	1985-10-26 09:15:00
@@ -40,9 +40,15 @@
   background: none;
 }
 
-/* brand */
+/*
+ * brand, with room for the focus ring of the link around the mark and the name, taken from
+ * the gutter at its left, as in the tab bar of the terminal frame
+ */
 .VPNav .VPNavBarTitle .title {
   gap: var(--ws-space-10);
+  width: fit-content;
+  margin-left: calc(-1 * var(--ws-space-10));
+  padding-inline: var(--ws-space-10);
   border-bottom: 0;
   color: var(--ws-color-text);
   font: var(--ws-text-label);
@@ -50,11 +56,16 @@
   letter-spacing: -0.02em;
 }
 
-/* a mark in a 64 box at 32 px draws each sprite pixel as 2 px */
+/*
+ * A mark in a 64 box at 32 px draws each sprite pixel as 2 px. A project's mark keeps two
+ * empty sprite columns on each side, 4 px here: pulled out by them, its pixels start where
+ * the brand's text would, on the edge of the page on a phone and of the sidebar's text above.
+ */
 .VPNav .VPNavBarTitle .logo {
   width: auto;
+  max-width: none;
   height: 2rem;
-  margin-right: 0;
+  margin-inline: calc(-1 * var(--ws-space-4));
   image-rendering: pixelated;
 }
 
@@ -367,12 +378,14 @@
     padding: 0 var(--ws-space-20) 0 0;
   }
 
-  /* the link is as wide as the brand, and a brand too long for the box is cut with an ellipsis */
-  .VPNav .VPNavBar .VPNavBarTitle .title {
-    width: fit-content;
-    max-width: 100%;
+  /*
+   * A brand too long for the box is cut with an ellipsis. The room for the ring at the right
+   * of the link is taken from the padding of the box, so the brand keeps the whole box.
+   */
+  .VPNav .VPNavBar .VPNavBarTitle .title {
+    max-width: calc(100% + 2 * var(--ws-space-10));
     height: var(--vp-nav-height);
-    padding: 0;
+    margin-right: calc(-1 * var(--ws-space-10));
   }
 
   .VPNav .VPNavBar .VPNavBarTitle .title > span {
Evidence: Status-line sweep script (Playwright, glyph-level)
// Drives both sample apps' production builds and checks the status line path, glyph by glyph:
// at every width it is either hidden as a whole, shown whole, or cut with an ellipsis after at
// least five drawn characters (design-system 0.8.1's contract). Also takes screenshots.
import { createRequire } from 'node:module'
import { spawn } from 'node:child_process'
import { writeFileSync } from 'node:fs'
import { setTimeout as sleep } from 'node:timers/promises'

const [root, out, tag = ''] = process.argv.slice(2)
const only = process.env.APPS ? process.env.APPS.split(',') : null
const require = createRequire(`${root}/react-checkout/package.json`)
const { chromium } = require('@playwright/test')

const apps = [
  { name: 'vue', dir: `${root}/vue-event-registration`, port: 4273,
    cmd: ['pnpm', ['exec', 'vite', 'preview', '--port', '4273', '--strictPort']], ready: null },
  { name: 'react', dir: `${root}/react-checkout`, port: 4274,
    cmd: ['pnpm', ['start']], ready: 'Place order' },
]

async function waitFor(url) {
  for (let i = 0; i < 100; i++) {
    try { if ((await fetch(url)).ok) return } catch {}
    await sleep(200)
  }
  throw new Error(`no server at ${url}`)
}

function measure() {
  const line = document.querySelector('.ws-status-line')
  const file = line.querySelector('.ws-status-line__file')
  const span = line.querySelector('.ws-status-line__file > span')
  const full = span.textContent
  const shown = file.checkVisibility()
  if (!shown) return { shown, full, drawn: '', cut: false, overflow: line.scrollWidth - line.clientWidth }
  const box = span.getBoundingClientRect()
  const style = getComputedStyle(span)
  const clipRight = box.right - parseFloat(style.paddingRight)
  const cut = span.scrollWidth > span.clientWidth
  // The ellipsis takes the room of one mono character at the end of the clip.
  const probe = document.createElement('span')
  probe.style.position = 'absolute'
  probe.style.font = style.font
  probe.textContent = '…'
  document.body.append(probe)
  const ellipsis = probe.getBoundingClientRect().width
  probe.remove()
  const limit = cut ? clipRight - ellipsis + 0.5 : clipRight + 0.5
  const node = span.firstChild
  let drawn = ''
  for (let i = 0; i < full.length; i++) {
    const r = document.createRange()
    r.setStart(node, i); r.setEnd(node, i + 1)
    if (r.getBoundingClientRect().right <= limit) drawn += full[i]
    else break
  }
  return { shown, full, drawn, cut, overflow: line.scrollWidth - line.clientWidth,
    fileWidth: file.getBoundingClientRect().width, font: style.fontFamily }
}

const results = {}
const run = apps.filter((a) => !only || only.includes(a.name))
const procs = []
let failures = 0
try {
  for (const app of run) {
    const p = spawn(app.cmd[0], app.cmd[1], { cwd: app.dir, detached: true, stdio: 'ignore',
      env: { ...process.env, PORT: String(app.port) } })
    procs.push(p)
  }
  for (const app of run) await waitFor(`http://localhost:${app.port}/`)
  const browser = await chromium.launch()
  for (const app of run) {
    const rows = []
    for (const keys of ['on', 'off']) {
      const context = await browser.newContext({ viewport: { width: 1280, height: 800 }, deviceScaleFactor: 2, colorScheme: process.env.COLOR ?? 'dark' })
      const page = await context.newPage()
      await page.goto(`http://localhost:${app.port}/`)
      if (app.ready) await page.getByRole('button', { name: app.ready }).first().waitFor(); await page.locator('.ws-status-line').waitFor()
      const sw = page.getByRole('switch', { name: 'Shortcut keys' })
      await sw.waitFor()
      if (keys === 'off') { await sw.click(); await page.waitForFunction(() => document.documentElement.dataset.wsKeys === 'off') }
      let firstShown = null
      for (let width = 300; width <= 1100; width++) {
        await page.setViewportSize({ width, height: 700 })
        const m = await page.evaluate(measure)
        const ok = m.overflow <= 0 && (!m.shown || !m.cut || m.drawn.length >= 5)
        if (!ok) failures++
        rows.push({ keys, width, ...m, ok })
        if (m.shown && firstShown === null) firstShown = { width, drawn: m.drawn }
      }
      // Screenshots of the status line at telling widths.
      const shots = [320, 360, 390, 412]
      if (firstShown) shots.push(firstShown.width)
      if (firstShown && firstShown.width > 300) shots.push(firstShown.width - 1)
      shots.push(1024, 1280)
      for (const w of [...new Set(shots)].sort((a, b) => a - b)) {
        await page.setViewportSize({ width: w, height: 700 })
        const m = await page.evaluate(measure)
        const file = `${out}/${tag}${app.name}-keys-${keys}-${w}px-status-line.png`
        await page.locator('.ws-status-line').screenshot({ path: file })
        console.log(`${app.name} keys=${keys} ${w}px: ${m.shown ? (m.cut ? `cut -> "${m.drawn}…" (${m.drawn.length} chars)` : `whole "${m.full}"`) : 'path hidden'} -> ${file.split('/').pop()}`)
      }
      if (keys === 'on') {
        await page.setViewportSize({ width: 320, height: 700 })
        await page.screenshot({ path: `${out}/${tag}${app.name}-320px-page.png` })
        await page.setViewportSize({ width: 1280, height: 800 })
        await page.screenshot({ path: `${out}/${tag}${app.name}-1280px-page.png` })
      }
      console.log(`${app.name} keys=${keys}: path first shows at ${firstShown?.width}px with "${firstShown?.drawn}"`)
      await context.close()
    }
    results[app.name] = rows
    const cuts = rows.filter((r) => r.shown && r.cut).map((r) => r.drawn.length)
    const hidden = rows.filter((r) => !r.shown).length
    console.log(`${app.name}: ${rows.length} widths, hidden at ${hidden}, cut at ${cuts.length} (fewest chars drawn when cut: ${cuts.length ? Math.min(...cuts) : 'n/a'}), whole at ${rows.filter((r) => r.shown && !r.cut).length}, failures ${rows.filter((r) => !r.ok).length}`)
  }
  await browser.close()
} finally {
  for (const p of procs) { try { process.kill(-p.pid, 'SIGTERM') } catch {} }
}
writeFileSync(`${out}/${tag}status-line-sweep.json`, JSON.stringify(results, null, 1))
console.log(failures === 0 ? 'SWEEP PASS' : `SWEEP FAIL: ${failures} widths broke the contract`)
process.exit(failures === 0 ? 0 : 1)

Pipeline

Updates from git push no-mistakes

✅ **Intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

  • Live validation: ✅ go - 6 of 7 scenarios driven live against the product
Scenario Result Live Evidence
A developer installs each sample app from its committed lockfile and gets design-system 0.8.1, and the production build succeeds ✅ pass live pnpm install --frozen-lockfile exited 0 in both apps, and node_modules/@whatsaaaa/design-system/package.json reads 0.8.1. The Playwright webServer ran vue-tsc -b &amp;&amp; vite build and `tsc -b && vite…
Vue app (vite preview of the production build): the status line stays whole while the theme and keys switches work, on desktop and Pixel 7 (existing frame e2e) ✅ pass live vue-frame-e2e.log: 9 passed, 1 skipped (the t-key test is desktop-only by design), including the 320-400px 'keeps the status line whole on a narrow screen' sweeps in both themes
React app (pnpm start, the production server with its API): the status line stays whole, the switches and forced-colors checks pass, on desktop and Pixel 7 (existing frame e2e) ✅ pass live react-frame-e2e.log: 21 passed, 1 skipped (desktop-only test)
On a phone width (320px) and every width from 300 to 1100px, keys on or off, the status-line path in both apps is never a 1-4 character stub: it is hidden as a whole, shown whole, or cut with an ellip… ✅ pass live status-line-sweep.log (dark) and after-0.8.1-light-status-line-sweep.log (light): fewest characters drawn when cut = 5 for both apps, 0 failures over 1,602 widths per app per theme, no line overflow.…
Adversarial before/after: with design-system 0.8.0 the Vue app shows a ~… stub at 320px, and the updated e2e assertion catches it; with 0.8.1 the stub is gone ✅ pass live before-0.8.0-light-vue-keys-on-320px-status-line.png shows ~…. before-0.8.0-light-status-line-sweep.log: 'fewest chars drawn when cut: 1', 57 failing widths. before-0.8.0-vue-frame-narrow-e2e.log: l…
On desktop widths (1024px and up) both apps show the full path (~/vue-event-registration, ~/react-checkout) in the status line ✅ pass live Sweep logs report 'whole' at 1024 and 1280px for both apps in both themes. Screenshots: react-keys-on-1280px-status-line.png, vue-keys-on-1280px-status-line.png, after-0.8.1-light-*-1024px-status-line…
Docs-theme brand mark: a site on the docs theme gets the edge-aligned logo with no margin of its own on .logo ⏸️ untested no Neither sample app uses the design system's VitePress docs theme or defines a .logo rule, so this repository has no docs-theme surface to drive. That part of 0.8.1 applies to docs sites, not to thes…
  • pnpm install --frozen-lockfile in vue-event-registration and react-checkout (both resolved @whatsaaaa/design-system 0.8.1)
  • pnpm exec playwright test e2e/frame.spec.ts in vue-event-registration (production build via vite preview, desktop + Pixel 7): 9 passed, 1 skipped (key-hint test is desktop-only)
  • pnpm exec playwright test e2e/frame.spec.ts in react-checkout (production build via pnpm start, desktop + Pixel 7): 21 passed, 1 skipped (desktop-only)
  • Ad hoc Playwright sweep scripts/status-line-sweep.mjs against both running production apps: each viewport width 300-1100px, keys on/off, dark theme; counts each drawn glyph before the ellipsis with Range rects, plus status-line screenshots
  • Same sweep with COLOR=light on 0.8.1 for both apps (the tighter case, because the theme name is rose-pine-dawn)
  • Regression repro: temporarily pnpm add @whatsaaaa/design-system@0.8.0 in vue-event-registration, then pnpm exec playwright test e2e/frame.spec.ts -g &#34;narrow screen&#34; --project=desktop (light theme fails with 'the path shows less than five characters') and APPS=vue COLOR=light sweep (57 widths broke the contract, ~… stub at 319-320px); then restored the committed files with git checkout and reinstalled 0.8.1
  • npm pack of 0.8.0 and 0.8.1 and diff -rq: only the status-line CSS (terminal.css/index.css) and the VitePress docs-theme nav.css changed
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

@whatsaaaa
whatsaaaa merged commit 94a3f3a into main Nov 16, 2026
2 checks passed
@whatsaaaa
whatsaaaa deleted the fm/samples-ds-081 branch November 16, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant