Repository navigation
fix: move both sample apps to design-system 0.8.1 - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Move the Vue and React sample apps to design system 0.8.1 (whatsaaaa/design-system#25), which hides the status line's path where it showed a one-letter stub and cuts it at five characters otherwise.
What Changed
@whatsaaaa/design-systemfrom^0.8.0to^0.8.1inreact-checkoutandvue-event-registration. Bothpackage.jsonfiles and lockfiles are updated, and each app'sminimumReleaseAgeExcludeentry inpnpm-workspace.yamlnow names 0.8.1 instead of 0.8.0.react-checkout/e2e/checks.ts,vue-event-registration/e2e/frame.spec.ts) to match 0.8.1. When the path shows, its text box must now fit five characters plus an ellipsis (xxxxx…), not just~…. When the path is hidden, there must not be room for those five characters and the ellipsis. The doc comments and assertion messages are updated to match.🤖 Generated with Claude Code
Risk Assessment
✅ Low: The change only bumps the design system from 0.8.0 to 0.8.1, a CSS and docs-only patch whose package.json differs from 0.8.0 only in its version, and the e2e path probe now matches the new 6ch threshold.
Testing
I installed both apps from their lockfiles (design-system 0.8.1) and ran each app's existing frame e2e spec against its production build, on desktop and Pixel 7. Both passed: Vue 9 passed with 1 skipped, React 21 passed with 1 skipped, and both include the 320-400px status-line sweep. As an independent check, I drove both running apps at every width from 300 to 1100px, in both themes and with the keys on or off, counting the characters actually drawn before the ellipsis. Every width either hid the path as a whole, showed it whole, or cut it after 5 or more characters, with no sideways overflow. I took status-line screenshots at 320, 360, 390, 412, 1024 and 1280px, plus the widths just before and after the path first shows. For before/after, I temporarily put 0.8.0 into the Vue app. It reproduced the
~…stub at 320px in the light theme, and the updated e2e assertion failed on it. Then I restored the committed 0.8.1 files. The docs-theme.logopart could not be exercised because neither app uses the docs theme. I removed all build, test and dependency outputs from the worktree and stopped every server.pnpm install --frozen-lockfileexited 0 in both apps, and node_modules/@whatsaaaa/design-system/package.json reads 0.8.1. The Playwright webServer ranvue-tsc -b && vite buildand `tsc -b && vite…pnpm start, the production server with its API): the status line stays whole, the switches and forced-colors checks pass, on desktop and Pixel 7 (existing frame e2e)~…stub at 320px, and the updated e2e assertion catches it; with 0.8.1 the stub is gone~…. before-0.8.0-light-status-line-sweep.log: 'fewest chars drawn when cut: 1', 57 failing widths. before-0.8.0-vue-frame-narrow-e2e.log: l…~/vue-event-registration,~/react-checkout) in the status line.logo.logorule, so this repository has no docs-theme surface to drive. That part of 0.8.1 applies to docs sites, not to thes…Evidence: Light-theme sweep on 0.8.1, both apps (SWEEP PASS)
vue: 1602 widths, hidden at 103, cut at 258 (fewest chars drawn when cut: 5), whole at 1241, failures 0 react: 1602 widths, hidden at 103, cut at 142 (fewest chars drawn when cut: 5), whole at 1357, failures 0 SWEEP PASSEvidence: Dark-theme sweep on 0.8.1, both apps (SWEEP PASS)
Evidence: Light-theme sweep on 0.8.0, Vue (reproduces the stub, SWEEP FAIL)
vue keys=on 319px: cut -> "…" (1 chars) vue keys=on 320px: cut -> "…" (1 chars) vue: 1602 widths, ... (fewest chars drawn when cut: 1), failures 57 SWEEP FAIL: 57 widths broke the contractEvidence: Updated Vue narrow-screen e2e fails on 0.8.0 (light theme)
✘ [desktop] in the light theme › keeps the status line whole on a narrow screen Error: the path shows less than five characters Expected: >= 43.203125 Received: 15.875Evidence: Vue frame e2e on 0.8.1 (9 passed, 1 skipped)
Evidence: React frame e2e on 0.8.1 (21 passed, 1 skipped)
Evidence: Published CSS diff, design-system 0.8.0 -> 0.8.1
Evidence: Status-line sweep script (Playwright, glyph-level)
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
pnpm install --frozen-lockfileexited 0 in both apps, and node_modules/@whatsaaaa/design-system/package.json reads 0.8.1. The Playwright webServer ranvue-tsc -b && vite buildand `tsc -b && vite…pnpm start, the production server with its API): the status line stays whole, the switches and forced-colors checks pass, on desktop and Pixel 7 (existing frame e2e)~…stub at 320px, and the updated e2e assertion catches it; with 0.8.1 the stub is gone~…. before-0.8.0-light-status-line-sweep.log: 'fewest chars drawn when cut: 1', 57 failing widths. before-0.8.0-vue-frame-narrow-e2e.log: l…~/vue-event-registration,~/react-checkout) in the status line.logo.logorule, so this repository has no docs-theme surface to drive. That part of 0.8.1 applies to docs sites, not to thes…pnpm install --frozen-lockfilein vue-event-registration and react-checkout (both resolved @whatsaaaa/design-system 0.8.1)pnpm exec playwright test e2e/frame.spec.tsin vue-event-registration (production build via vite preview, desktop + Pixel 7): 9 passed, 1 skipped (key-hint test is desktop-only)pnpm exec playwright test e2e/frame.spec.tsin react-checkout (production build viapnpm start, desktop + Pixel 7): 21 passed, 1 skipped (desktop-only)Ad hoc Playwright sweepscripts/status-line-sweep.mjsagainst both running production apps: each viewport width 300-1100px, keys on/off, dark theme; counts each drawn glyph before the ellipsis with Range rects, plus status-line screenshotsSame sweep withCOLOR=lighton 0.8.1 for both apps (the tighter case, because the theme name isrose-pine-dawn)Regression repro: temporarilypnpm add @whatsaaaa/design-system@0.8.0in vue-event-registration, thenpnpm exec playwright test e2e/frame.spec.ts -g "narrow screen" --project=desktop(light theme fails with 'the path shows less than five characters') andAPPS=vue COLOR=lightsweep (57 widths broke the contract,~…stub at 319-320px); then restored the committed files withgit checkoutand reinstalled 0.8.1npm packof 0.8.0 and 0.8.1 anddiff -rq: only the status-line CSS (terminal.css/index.css) and the VitePress docs-theme nav.css changed✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.