Repository navigation
feat: set up Astro landing site with projects, ideas and GitHub Pages deploy - #1
Merged
Merged
Conversation
Scaffold an Astro 7 site for the GitHub Pages user site: home page with placeholder intro and featured projects, /projects and /ideas from typed content collections (seeded with form-builder and marked placeholders), 404 page, favicon, sitemap and meta tags. Add Prettier and ESLint, a CI workflow for pull requests and a deploy workflow using withastro/action and actions/deploy-pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Yes please proceed with the Astro setup under whatsaaaa.github.io repo, create a temporary home page with your content suggestions and we will improve it later. Also, use Github Actions for deployment
Context: whatsaaaa.github.io is the GitHub Pages user site repository, served at the root https://whatsaaaa.github.io/. It is a personal landing page to showcase the owner's projects, tools and ideas. Project sites from other repos live under it at their own paths (e.g. the form-builder docs at https://whatsaaaa.github.io/form-builder/), so the site must not use a /form-builder path. The suggested content was: a home page; a projects section driven by Astro content collection files (each project a Markdown file with fields like title, description, tags, links and status), with form-builder as the first entry (JSON-defined Formisch forms compiled to typed Valibot schemas; repo https://github.com/whatsaaaa/form-builder, docs https://whatsaaaa.github.io/form-builder/, npm packages @whatsaaaa/form-builder-schema, -affects, -vue, -react); and optional notes or ideas pages. Astro was chosen for fast static output, islands for occasional Vue/React components, content collections and the official GitHub Pages action. The repo is public and Pages is already set to deploy from GitHub Actions.
What Changed
site: https://whatsaaaa.github.io, with sitemap integration). It adds a sharedBaselayout, global styles, a home page, a 404 page,/projects/and/ideas/index and detail pages, andProjectCardandStatusBadgecomponents. It also adds a favicon and arobots.txtthat allows every path, so project sites under the domain (such as/form-builder/) are not blocked.projectsandideascontent collections with Zod-validated frontmatter: title, description, status, tags, links, featured flag and date for projects. The first project entry isform-builder, alongside placeholder entries for a next project and an idea.astro checkand pnpm scripts. Adeploy.ymlworkflow builds the site withwithastro/actionon Node 24 and publishes it withactions/deploy-pageson every push tomainor on manual dispatch. Aci.ymlworkflow runs format check, lint,astro checkand a build on pull requests. The README now covers development, how to add projects and ideas, and deployment.🤖 Generated with Claude Code
Risk Assessment
✅ Low: This is a new static Astro site with no user data or auth. Both fixes from round 1 are in place and correct: deploy.yml now passes node-version 24 to withastro/action, matching CI, and robots.txt has the comment the owner asked for with its directives unchanged. Re-reviewing the rest of the files turned up no new defects or conflicts with the intent.
Testing
I built the site with pnpm and served it with
astro preview, then drove it in headless Chrome. The home page, the projects index, the form-builder detail page (including its docs, repo and npm links), the ideas index and idea page, and the 404 page all rendered with correct navigation, and the screenshots look visually clean on both desktop and narrow viewports. The top-level /form-builder/ path returns 404, and every sitemap URL sits at the root under /projects/ or /ideas/. In a disposable copy, a project file with invalid frontmatter failed the build with a clear schema error, and a valid new project file was published and listed automatically. The GitHub Actions deploy workflow could not run, because it needs GitHub's runners and the Pages deployment environment;actis not available locally. Its build step is the sameastro buildthat passed here. All scenarios I could drive passed.actis not installed. The deploy run on G…Evidence: Build rejects invalid project frontmatter
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
.github/workflows/deploy.yml:22- The deploy job runswithastro/action@v6without anode-versioninput, so production builds use the action's default Node, while CI (ci.yml:21) pins Node 24 andpackage.json:6setsengines.node >=22.23.4. If the action's default Node and CI's Node drift apart, a PR can pass CI on 24 and then fail or behave differently in the deploy build. Fix: passwith: node-version: 24towithastro/actionso the build that ships uses the same Node as the build CI checked..github/workflows/ci.yml:1- Simplification: the intent asks for GitHub Actions for deployment. This PR-only CI workflow (format check, lint, astro check, build), plus the ESLint/Prettier tooling it runs (eslint.config.js,.prettierrc.json,.prettierignore, and the lint/format devDependencies and scripts inpackage.json), goes beyond that. It fits the owner's general quality preferences but no requirement in the intent calls for it. Confirm whether to keep it or remove it.astro.config.mjs:10- Simplification: the@astrojs/sitemapintegration,public/robots.txt, and the<link rel="sitemap">insrc/layouts/Base.astro:37are not required by the intent (home page, projects collection, optional ideas pages, Actions deployment). Becauserobots.txtsits at the domain root, it also governs crawling of the other repos' project sites, such as /form-builder/. Confirm whether to keep these or remove them.🔧 Fix applied.
1 warning still open:
.github/workflows/ci.yml:1- Simplification: the intent asks for GitHub Actions for deployment. This PR-only CI workflow (format check, lint, astro check, build), plus the ESLint/Prettier tooling it runs (eslint.config.js,.prettierrc.json,.prettierignore, and the lint/format devDependencies and scripts inpackage.json), goes beyond that. It fits the owner's general quality preferences but no requirement in the intent calls for it. Confirm whether to keep it or remove it.✅ **Test** - passed
✅ No issues found.
actis not installed. The deploy run on G…pnpm install --frozen-lockfilethenpnpm build(7 static pages plus sitemap, exit 0)pnpm preview --port 4391driven with chrome-devtools-axi (Chrome for Testing 157, isolated session): opened /, clicked the form-builder card through to /projects/form-builder/, then opened /projects/, /ideas/, /ideas/placeholder-idea/ and /does-not-exist/curlhttp://localhost:4391/form-builder/ returned 404, so the site publishes nothing at the other repo's path500px-wide viewport screenshot of the project page, with a scrollWidth check showing no horizontal overflowDisposable copy in /tmp: added src/content/projects/bad.md (status 'shipped', no date) and ranastro build, which exited 1 with InvalidContentEntryDataErrorDisposable copy: added a valid demo-tool.md project and ranastro build, which exited 0; /projects/demo-tool/ was generated, listed in projects/index.html and added to the sitemap✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.