Skip to content

fix: adopt design-system 0.8.0 and drop the workarounds it covers - #5

Merged
whatsaaaa merged 1 commit into
mainfrom
fm/ds-adopt-gaps-2
Nov 16, 2026
Merged

whatsaaaa merged 1 commit into
mainfrom
fm/ds-adopt-gaps-2

Conversation

@whatsaaaa

@whatsaaaa whatsaaaa commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Intent

Move the website to design system 0.8.0, which closes the gaps the website, the form-builder docs and the sample apps found when they adopted 0.6.1 (whatsaaaa/design-system#23), and drop the local workarounds the release now covers, following its migration notes.

What Changed

  • Moves @whatsaaaa/design-system from ^0.6.1 to ^0.8.0 in package.json and pnpm-lock.yaml.
  • src/layouts/Base.astro now writes the two theme-color <meta> tags from themeColorMeta (@whatsaaaa/design-system/theme/meta) into the head in the page as sent. The browser bar takes the theme's background even without JavaScript, and themeInitScript keeps it in step with the theme shown.
  • src/styles/global.css drops the local rule that padded the status line items by 10px below 64rem, because 0.8.0 now provides that padding. It also renames the phone pane comment to call it the phone gutter.

Workarounds checked against 0.8.0

  • Status line padding of 10 px below 64rem: removed. 0.8.0 pads every status line item 10 px below 64rem. Its path container query now allows for that padding too.
  • theme-color: the site had no tag of its own and no script of its own setting the color, so there was nothing to remove. The two tags are now written from themeColorMeta, as 0.8.0 asks.
  • 16 px phone gutter: kept as it is. The site already pads .pane and .column with var(--ws-space-16) below 64rem, which is exactly the phone gutter the usage guide now names. There is no local value to remove; only the comment now calls it the phone gutter.
  • Icons at 1rem or --ws-space-16: none. The site draws no icons, and every --ws-space-16 use is spacing. The calendar icon, the 40rem breakpoint and ws-pairs-group are not used by the site.
  • Kept on purpose (site choices from fix: adopt @whatsaaaa/design-system 0.6.1 and drop covered workarounds #4, not gaps of the system): the cat ~/projects/<name>.md prompt in place of ws-crumb, and the status line showing only the file name below 64rem.
  • minimumReleaseAgeExclude: ['@whatsaaaa/design-system'] stays, because 0.8.0 was published on 2026-11-15.

No design-system gaps remain for the site.

Visible changes

Full-page screenshots of / and /projects/form-builder/, on main and on this branch, in both themes, at 320, 390 and 1440 px, compared pixel by pixel:

  • 10 of the 12 pairs are pixel-identical.
  • Light theme, 320 px, both pages: the status line now shows the path as its first letter and an ellipsis (w… on the home page) where main left an empty path cell. On main, the path's container query still hard-coded the 14 px padding even though the site padded the items 10 px, so the path was hidden too soon. 0.8.0's query matches the 10 px padding ("the path keeps about 32 px more"), as the release intends. Nothing else in the status line moves. At 320 px in the dark theme the path did not change.
  • Without JavaScript: the page now sends the two theme-color tags, #191724 for dark, then #faf4ed for a light system. Main sent none.

🤖 Generated with Claude Code

Risk Assessment

✅ Low: A small dependency bump that drops one site CSS rule (now in design system 0.8.0) and adds the two theme-color tags from themeColorMeta, matching the 0.8.0 migration notes and usage guide. All tokens, classes and exports the site uses exist in 0.8.0.

Testing

I built the target and the base commit (design system 0.6.1), served both with astro preview, and checked them with curl and headless Chromium through Playwright. All six served pages carry the two theme-color tags with the right values: #191724 for dark, then #faf4ed for light. The base build sent none. With JavaScript off, the tags stay as sent. With JavaScript on, the head script keeps both tags matched to the visible theme through toggling, reloading with a saved theme, and system theme changes. It never adds a third tag. The design system now gives the status line 10px padding at 390px and 14px at 1280px. Nothing overflows sideways. The phone gutter lines content up with the brand. Target and base screenshots match pixel for pixel on two pages at both widths. All scenarios passed. Screenshots, the served-head extract and the measurements JSON are saved in the evidence directory. The preview servers and throwaway files have been removed.

  • Live validation: ✅ go - 7 of 7 scenarios driven live against the product
Scenario Result Live Evidence
The site builds on design-system 0.8.0: pnpm build at the target commit produces every page ✅ pass live build-target.log: exit=0, 10 page(s) built, sitemap created
A visitor without JavaScript, or a link preview, gets the two theme-color tags in the HTML as sent (dark #191724 first with 'not all and (prefers-color-scheme: light)', then light #faf4ed with '(prefe… ✅ pass live served-head-theme-color.txt (curl of 6 pages from astro preview on 127.0.0.1:4401); browser-measurements.json themeColor['target noJS light'] and nojs-light-phone390-home-target.png
Adversarial: the head script keeps the tags matched to the visible theme without duplicating them. Steps: light system, click the status line theme button, reload with the saved theme, click again, sw… ✅ pass live browser-measurements.json themeColor entries; js-light-phone390-home-target-before-toggle.png and -after-toggle.png
On a 390px phone, the status line pads mode, file, keys switch and theme 10px from the design system alone, now that the local rule is gone; the path stays readable and nothing overflows ✅ pass live browser-measurements.json 'target phone390 /' and '/projects/form-builder/'; phone390-*-status-line-target.png
On a 1280px desktop, the status line items keep the 14px padding (the system's phone rule does not leak to wide screens) ✅ pass live browser-measurements.json 'target desktop1280 /' and '/projects/form-builder/'
Dropping the local status line workaround changes nothing a visitor sees: target and base (0.6.1 plus workaround) screenshots are pixel-identical ✅ pass live browser-measurements.json pixelDiffTargetVsBase; phone390--target.png vs phone390--base.png and desktop1280--target.png vs desktop1280--base.png
Phone gutter: on a 390px phone, pane and page content starts at the same x as the tab-bar brand, 16px inside the window ✅ pass live browser-measurements.json gutter entries for target phone390 / and /projects/form-builder/
Evidence: Served HTML theme-color tags on 6 pages (target) and on / (base, no tags)
== target GET / (status 200)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>
<script>
<script type="module" src="/_astro/Base.astro_astro_type_script_index_0_lang.Dkja2v4E.js">
== target GET /projects/ (status 200)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>
<script>
<script type="module" src="/_astro/Base.astro_astro_type_script_index_0_lang.Dkja2v4E.js">
== target GET /projects/form-builder/ (status 200)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>
<script>
<script type="module" src="/_astro/Base.astro_astro_type_script_index_0_lang.Dkja2v4E.js">
== target GET /ideas/ (status 200)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>
<script>
<script type="module" src="/_astro/Base.astro_astro_type_script_index_0_lang.Dkja2v4E.js">
== target GET /ideas/vue-component-library/ (status 200)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>
<script>
<script type="module" src="/_astro/Base.astro_astro_type_script_index_0_lang.Dkja2v4E.js">
== target GET /404.html (status 200)
<meta name="theme-color" content="#191724" media="not all and (prefers-color-scheme: light)">
<meta name="theme-color" content="#faf4ed" media="(prefers-color-scheme: light)">
<script>
<script>
<script type="module" src="/_astro/Base.astro_astro_type_script_index_0_lang.Dkja2v4E.js">
<script type="module">
== base GET / (before the change)
(no theme-color tag in the served HTML)
Evidence: Browser measurements: status line padding, overflow, gutter, pixel diff, theme-color states
{
  "target phone390 /": {
    "innerWidth": 390,
    ".ws-status-line__mode": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "10px 10px",
      "shown": true
    },
    "path": {
      "text": "whatsaaaa",
      "cut": false,
      "width": 85
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 390,
        "clientWidth": 390,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 12,
      "brandContentX": 29,
      "contentX": 29,
      "gutterPx": 17,
      "aligned": true
    }
  },
  "target phone390 /projects/form-builder/": {
    "innerWidth": 390,
    ".ws-status-line__mode": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "10px 10px",
      "shown": true
    },
    "path": {
      "text": "form-builder.md",
      "cut": false,
      "width": 128
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 390,
        "clientWidth": 390,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 12,
      "brandContentX": 29,
      "contentX": 29,
      "gutterPx": 17,
      "aligned": true
    }
  },
  "target desktop1280 /": {
    "innerWidth": 1280,
    ".ws-status-line__mode": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "14px 14px",
      "shown": true
    },
    "path": {
      "text": "~/whatsaaaa",
      "cut": false,
      "width": 107
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 1280,
        "clientWidth": 1280,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 20,
      "brandContentX": 41,
      "contentX": 69,
      "gutterPx": 49,
      "aligned": false
    }
  },
  "target desktop1280 /projects/form-builder/": {
    "innerWidth": 1280,
    ".ws-status-line__mode": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "14px 14px",
      "shown": true
    },
    "path": {
      "text": "~/projects/form-builder.md",
      "cut": false,
      "width": 215
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 1280,
        "clientWidth": 1280,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 20,
      "brandContentX": 41,
      "contentX": 296,
      "gutterPx": 276,
      "aligned": false
    }
  },
  "base phone390 /": {
    "innerWidth": 390,
    ".ws-status-line__mode": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "10px 10px",
      "shown": true
    },
    "path": {
      "text": "whatsaaaa",
      "cut": false,
      "width": 85
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 390,
        "clientWidth": 390,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 12,
      "brandContentX": 29,
      "contentX": 29,
      "gutterPx": 17,
      "aligned": true
    }
  },
  "base phone390 /projects/form-builder/": {
    "innerWidth": 390,
    ".ws-status-line__mode": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "10px 10px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "10px 10px",
      "shown": true
    },
    "path": {
      "text": "form-builder.md",
      "cut": false,
      "width": 128
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 390,
        "clientWidth": 390,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 364,
        "clientWidth": 364,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 12,
      "brandContentX": 29,
      "contentX": 29,
      "gutterPx": 17,
      "aligned": true
    }
  },
  "base desktop1280 /": {
    "innerWidth": 1280,
    ".ws-status-line__mode": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "14px 14px",
      "shown": true
    },
    "path": {
      "text": "~/whatsaaaa",
      "cut": false,
      "width": 107
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 1280,
        "clientWidth": 1280,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 20,
      "brandContentX": 41,
      "contentX": 69,
      "gutterPx": 49,
      "aligned": false
    }
  },
  "base desktop1280 /projects/form-builder/": {
    "innerWidth": 1280,
    ".ws-status-line__mode": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__file": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__switch": {
      "padding": "14px 14px",
      "shown": true
    },
    ".ws-status-line__theme": {
      "padding": "14px 14px",
      "shown": true
    },
    "path": {
      "text": "~/projects/form-builder.md",
      "cut": false,
      "width": 215
    },
    "overflow": {
      "documentElement": {
        "scrollWidth": 1280,
        "clientWidth": 1280,
        "fits": true
      },
      ".ws-term": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-tab-bar": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      },
      ".ws-status-line": {
        "scrollWidth": 1238,
        "clientWidth": 1238,
        "fits": true
      }
    },
    "gutter": {
      "windowLeft": 20,
      "brandContentX": 41,
      "contentX": 296,
      "gutterPx": 276,
      "aligned": false
    }
  },
  "pixelDiffTargetVsBase": {
    "phone390 /": {
      "differingPixels": 0,
      "of": 1316640,
      "box": null
    },
    "phone390 / status": {
      "differingPixels": 0,
      "of": 48048,
      "box": null
    },
    "phone390 /projects/form-builder/": {
      "differingPixels": 0,
      "of": 1316640,
      "box": null
    },
    "phone390 /projects/form-builder/ status": {
      "differingPixels": 0,
      "of": 48048,
      "box": null
    },
    "desktop1280 /": {
      "differingPixels": 0,
      "of": 4096000,
      "box": null
    },
    "desktop1280 / status": {
      "differingPixels": 0,
      "of": 158464,
      "box": null
    },
    "desktop1280 /projects/form-builder/": {
      "differingPixels": 0,
      "of": 4096000,
      "box": null
    },
    "desktop1280 /projects/form-builder/ status": {
      "differingPixels": 0,
      "of": 158464,
      "box": null
    }
  },
  "themeColor": {
    "target noJS light": {
      "tags": [
        {
          "content": "#191724",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#faf4ed",
          "media": "(prefers-color-scheme: light)"
        }
      ],
      "dataTheme": null,
      "keysAttr": null
    },
    "base noJS light": {
      "tags": [],
      "dataTheme": null,
      "keysAttr": null
    },
    "target JS light load": {
      "tags": [
        {
          "content": "#faf4ed",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#faf4ed",
          "media": "(prefers-color-scheme: light)"
        }
      ],
      "bg": "rgb(250, 244, 237)",
      "themeName": "Switch theme, now\nrose-pine-dawn",
      "dataTheme": null
    },
    "target JS light, after clicking theme button": {
      "tags": [
        {
          "content": "#191724",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#191724",
          "media": "(prefers-color-scheme: light)"
        }
      ],
      "bg": "rgb(25, 23, 36)",
      "themeName": "Switch theme, now\nrose-pine",
      "dataTheme": "dark"
    },
    "target JS light, after reload (remembered dark)": {
      "tags": [
        {
          "content": "#191724",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#191724",
          "media": "(prefers-color-scheme: light)"
        }
      ],
      "bg": "rgb(25, 23, 36)",
      "themeName": "Switch theme, now\nrose-pine",
      "dataTheme": "dark"
    },
    "target JS light, toggled back": {
      "tags": [
        {
          "content": "#faf4ed",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#faf4ed",
          "media": "(prefers-color-scheme: light)"
        }
      ],
      "bg": "rgb(250, 244, 237)",
      "themeName": "Switch theme, now\nrose-pine-dawn",
      "dataTheme": "light"
    },
    "target JS dark load /projects/": {
      "tags": [
        {
          "content": "#191724",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#191724",
          "media": "(prefers-color-scheme: light)"
        }
      ]
    },
    "target JS, system switches dark->light with no choice by hand": {
      "tags": [
        {
          "content": "#faf4ed",
          "media": "not all and (prefers-color-scheme: light)"
        },
        {
          "content": "#faf4ed",
          "media": "(prefers-color-scheme: light)"
        }
      ],
      "bg": "rgb(250, 244, 237)"
    }
  }
}
Evidence: Target build log
$ astro build
12:15:05 [content] Syncing content
12:15:05 [content] Synced content
12:15:05 [types] Generated 1.20s
12:15:05 [build] output: "static"
12:15:05 [build] mode: "static"
12:15:05 [build] directory: {run-worktree}/dist/
12:15:05 [build] Collecting build info...
12:15:05 [build] ✓ Completed in 1.24s.
12:15:05 [build] Building static entrypoints...
12:15:06 [vite] ✓ built in 1.18s
12:15:06 [vite] ✓ built in 51ms
12:15:06 [build] Rearranging server assets...

 generating static routes 
12:15:06   ├─ /404.html (+43ms) 
12:15:06   ├─ /ideas/react-component-library/index.html (+7ms) 
12:15:06   ├─ /ideas/vue-component-library/index.html (+4ms) 
12:15:06   ├─ /ideas/index.html (+7ms) 
12:15:06   ├─ /projects/design-system/index.html (+5ms) 
12:15:06   ├─ /projects/form-builder/index.html (+3ms) 
12:15:06   ├─ /projects/building-blocks/index.html (+3ms) 
12:15:06   ├─ /projects/dotfiles/index.html (+3ms) 
12:15:06   ├─ /projects/index.html (+6ms) 
12:15:06   ├─ /index.html (+6ms) 
12:15:06 ✓ Completed in 175ms.

12:15:06 [build] ✓ Completed in 1.49s.
12:15:06 [@astrojs/sitemap] `sitemap-index.xml` created at `dist`
12:15:06 [build] 10 page(s) built in 2.74s
12:15:06 [build] Complete!
exit=0

Phone 390px status line on form-builder page (target, 0.8.0)

Phone 390px status line on form-builder page (base, 0.6.1 + workaround)

Phone 390px home (target)

Phone 390px form-builder page (target)

Desktop 1280px home (target)

Desktop 1280px status line on form-builder page (target)

No-JavaScript visitor, light system, phone 390px (target)

Light system before clicking the status line theme button

After clicking the status line theme button (dark, rose-pine)

Evidence: Target vs base pixel diff
phone390 / : 0 differing pixels of 1316640; phone390 /projects/form-builder/ : 0 of 1316640; desktop1280 / : 0 of 4096000; desktop1280 /projects/form-builder/ : 0 of 4096000; status line crops: 0 differing pixels at both widths

Pipeline

Updates from git push no-mistakes

✅ **Intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

  • Live validation: ✅ go - 7 of 7 scenarios driven live against the product
Scenario Result Live Evidence
The site builds on design-system 0.8.0: pnpm build at the target commit produces every page ✅ pass live build-target.log: exit=0, 10 page(s) built, sitemap created
A visitor without JavaScript, or a link preview, gets the two theme-color tags in the HTML as sent (dark #191724 first with 'not all and (prefers-color-scheme: light)', then light #faf4ed with '(prefe… ✅ pass live served-head-theme-color.txt (curl of 6 pages from astro preview on 127.0.0.1:4401); browser-measurements.json themeColor['target noJS light'] and nojs-light-phone390-home-target.png
Adversarial: the head script keeps the tags matched to the visible theme without duplicating them. Steps: light system, click the status line theme button, reload with the saved theme, click again, sw… ✅ pass live browser-measurements.json themeColor entries; js-light-phone390-home-target-before-toggle.png and -after-toggle.png
On a 390px phone, the status line pads mode, file, keys switch and theme 10px from the design system alone, now that the local rule is gone; the path stays readable and nothing overflows ✅ pass live browser-measurements.json 'target phone390 /' and '/projects/form-builder/'; phone390-*-status-line-target.png
On a 1280px desktop, the status line items keep the 14px padding (the system's phone rule does not leak to wide screens) ✅ pass live browser-measurements.json 'target desktop1280 /' and '/projects/form-builder/'
Dropping the local status line workaround changes nothing a visitor sees: target and base (0.6.1 plus workaround) screenshots are pixel-identical ✅ pass live browser-measurements.json pixelDiffTargetVsBase; phone390--target.png vs phone390--base.png and desktop1280--target.png vs desktop1280--base.png
Phone gutter: on a 390px phone, pane and page content starts at the same x as the tab-bar brand, 16px inside the window ✅ pass live browser-measurements.json gutter entries for target phone390 / and /projects/form-builder/
  • pnpm build at the target commit (exit 0, 10 pages)
  • Base commit 8784875 extracted with git archive, installed with pnpm install --frozen-lockfile --ignore-workspace (design-system 0.6.1) and built, used as the before side
  • astro preview serving the target on 127.0.0.1:4401 and the base on 127.0.0.1:4402
  • curl of /, /projects/, /projects/form-builder/, /ideas/, /ideas/vue-component-library/ and /404.html, pulling out the theme-color tags from the HTML as sent
  • Playwright (playwright-core in a throwaway temp dir, cached Chrome for Testing): measured the status line padding of mode, file, switch and theme at 390px and 1280px on / and /projects/form-builder/
  • Playwright: checked scrollWidth <= clientWidth for documentElement, .ws-term, .ws-tab-bar and .ws-status-line at 390px and 1280px, following the usage.md checklist
  • Playwright: checked the phone gutter by comparing the content x of the pane and the column with the content x of the tab-bar brand at 390px
  • Playwright: compared target and base screenshots pixel by pixel (full viewport and status line crop) at 390px and 1280px on 2 pages
  • Playwright: with JavaScript turned off and a light system theme, read the theme-color tags and took a screenshot (target and base)
  • Playwright: with JavaScript on and a light system theme, loaded the page, clicked the status line theme button, reloaded (theme remembered), clicked it again, then switched the system theme from dark to light; read the tag contents, count, body background and theme name at each step
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

The status line's 10px item padding below 64rem now comes from the system,
whose path container query matches it. The two theme-color tags are written
into the head as sent from themeColorMeta, so visitors without JavaScript and
link previews get the browser bar color.
@whatsaaaa
whatsaaaa merged commit 78a3d6f into main Nov 16, 2026
1 check passed
@whatsaaaa
whatsaaaa deleted the fm/ds-adopt-gaps-2 branch November 16, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant