Repository navigation
fix: adopt design-system 0.8.0 and drop the workarounds it covers - #5
Merged
Merged
Conversation
The status line's 10px item padding below 64rem now comes from the system, whose path container query matches it. The two theme-color tags are written into the head as sent from themeColorMeta, so visitors without JavaScript and link previews get the browser bar color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Move the website to design system 0.8.0, which closes the gaps the website, the form-builder docs and the sample apps found when they adopted 0.6.1 (whatsaaaa/design-system#23), and drop the local workarounds the release now covers, following its migration notes.
What Changed
@whatsaaaa/design-systemfrom^0.6.1to^0.8.0inpackage.jsonandpnpm-lock.yaml.src/layouts/Base.astronow writes the two theme-color<meta>tags fromthemeColorMeta(@whatsaaaa/design-system/theme/meta) into the head in the page as sent. The browser bar takes the theme's background even without JavaScript, andthemeInitScriptkeeps it in step with the theme shown.src/styles/global.cssdrops the local rule that padded the status line items by 10px below 64rem, because 0.8.0 now provides that padding. It also renames the phone pane comment to call it the phone gutter.Workarounds checked against 0.8.0
themeColorMeta, as 0.8.0 asks..paneand.columnwithvar(--ws-space-16)below 64rem, which is exactly the phone gutter the usage guide now names. There is no local value to remove; only the comment now calls it the phone gutter.1remor--ws-space-16: none. The site draws no icons, and every--ws-space-16use is spacing. The calendar icon, the 40rem breakpoint andws-pairs-groupare not used by the site.cat ~/projects/<name>.mdprompt in place ofws-crumb, and the status line showing only the file name below 64rem.minimumReleaseAgeExclude: ['@whatsaaaa/design-system']stays, because 0.8.0 was published on 2026-11-15.No design-system gaps remain for the site.
Visible changes
Full-page screenshots of
/and/projects/form-builder/, on main and on this branch, in both themes, at 320, 390 and 1440 px, compared pixel by pixel:w…on the home page) where main left an empty path cell. On main, the path's container query still hard-coded the 14 px padding even though the site padded the items 10 px, so the path was hidden too soon. 0.8.0's query matches the 10 px padding ("the path keeps about 32 px more"), as the release intends. Nothing else in the status line moves. At 320 px in the dark theme the path did not change.#191724for dark, then#faf4edfor a light system. Main sent none.🤖 Generated with Claude Code
Risk Assessment
✅ Low: A small dependency bump that drops one site CSS rule (now in design system 0.8.0) and adds the two theme-color tags from themeColorMeta, matching the 0.8.0 migration notes and usage guide. All tokens, classes and exports the site uses exist in 0.8.0.
Testing
I built the target and the base commit (design system 0.6.1), served both with
astro preview, and checked them with curl and headless Chromium through Playwright. All six served pages carry the two theme-color tags with the right values: #191724 for dark, then #faf4ed for light. The base build sent none. With JavaScript off, the tags stay as sent. With JavaScript on, the head script keeps both tags matched to the visible theme through toggling, reloading with a saved theme, and system theme changes. It never adds a third tag. The design system now gives the status line 10px padding at 390px and 14px at 1280px. Nothing overflows sideways. The phone gutter lines content up with the brand. Target and base screenshots match pixel for pixel on two pages at both widths. All scenarios passed. Screenshots, the served-head extract and the measurements JSON are saved in the evidence directory. The preview servers and throwaway files have been removed.pnpm buildat the target commit produces every pageEvidence: Served HTML theme-color tags on 6 pages (target) and on / (base, no tags)
Evidence: Browser measurements: status line padding, overflow, gutter, pixel diff, theme-color states
Evidence: Target build log
Evidence: Target vs base pixel diff
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
pnpm buildat the target commit produces every pagepnpm buildat the target commit (exit 0, 10 pages)Base commit 8784875 extracted withgit archive, installed withpnpm install --frozen-lockfile --ignore-workspace(design-system 0.6.1) and built, used as the before sideastro previewserving the target on 127.0.0.1:4401 and the base on 127.0.0.1:4402curlof /, /projects/, /projects/form-builder/, /ideas/, /ideas/vue-component-library/ and /404.html, pulling out the theme-color tags from the HTML as sentPlaywright (playwright-core in a throwaway temp dir, cached Chrome for Testing): measured the status line padding of mode, file, switch and theme at 390px and 1280px on / and /projects/form-builder/Playwright: checked scrollWidth <= clientWidth for documentElement, .ws-term, .ws-tab-bar and .ws-status-line at 390px and 1280px, following the usage.md checklistPlaywright: checked the phone gutter by comparing the content x of the pane and the column with the content x of the tab-bar brand at 390pxPlaywright: compared target and base screenshots pixel by pixel (full viewport and status line crop) at 390px and 1280px on 2 pagesPlaywright: with JavaScript turned off and a light system theme, read the theme-color tags and took a screenshot (target and base)Playwright: with JavaScript on and a light system theme, loaded the page, clicked the status line theme button, reloaded (theme remembered), clicked it again, then switched the system theme from dark to light; read the tag contents, count, body background and theme name at each step✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.