Repository navigation
fix: move the site to @whatsaaaa/design-system 0.8.1 - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Move the website to design system 0.8.1 (whatsaaaa/design-system#25), which hides the status line's path where it showed a one-letter stub and cuts it at five characters otherwise.
What Changed
@whatsaaaa/design-systemfrom^0.8.0to^0.8.1inpackage.json, andpnpm-lock.yamlnow resolves 0.8.1 with its new integrity hash.src/components/StatusLine.astrogets 0.8.1's path fix without any edits: the path is cut with an ellipsis down to five characters and hides completely when there is less room, so 320px phones no longer show a one-letter stub likew…. The site doesn't use the docs theme and has no.logomargin of its own, so there was nothing to drop.🤖 Generated with Claude Code
Risk Assessment
✅ Low: This is a patch bump of the site's own design system from 0.8.0 to 0.8.1: the package.json range and the lockfile change together, the lockfile hash matches the npm registry, and the package's code changes are limited to the status-line path cutoff and the docs theme's brand, which this Astro site takes as-is without needing a change of its own.
Testing
Installed with the frozen lockfile and built the site on 0.8.1. I also built a disposable 0.8.0 baseline from the base commit, served both with
astro preview, and drove them in headless Chrome for Testing. A 280-1400px width sweep over seven pages reproduced the bug on 0.8.0 (path cut to 1-4 characters, e.g.wha…, at 283-311px). On 0.8.1 no page ever shows fewer than five characters before the ellipsis: the path hides whole below 312px and otherwise shows five or more characters or the full name. Mobile-emulated runs at 300, 320 and 375px and a 1280px desktop run gave the same result. Before/after screenshots show 0.8.0'swha…stub replaced by a clean status line on 0.8.1. They also showform-b…at 320px, the full~/projects/form-builder.mdon desktop, and an unchanged tab bar on phones. Diffing the two builds shows only the two status line container-query thresholds changed. Overall result: pass. All temporary servers, the browser session, the baseline copy and build outputs were removed.pnpm install --frozen-lockfileresolves @whatsaaaa/design-system 0.8.1 andpnpm buildproduces the static sitepnpm install --frozen-lockfileprinted '+ @whatsaaaa/design-system 0.8.1';pnpm buildexit 0, 10 pages built (build-0.8.1.log); the built CSS carries the 0.8.1 thresholds calc(6ch + 1.75rem) / cal….logomargin removal do not apply).logorule or docs-theme import; built HTML differs from 0.8.0 only in the stylesheet hashEvidence: Width sweep summary 280-1400px, 0.8.0 vs 0.8.1, 7 pages
0.8.0 / 280-282 hidden | 283-289 cut:1 | 290-296 cut:2 | 297-303 cut:3 | 304-311 cut:4 | 312-318 cut:5 | ... | 333-1023 full:whatsaaaa | 1024-1400 full:/whatsaaaa 0.8.1 / 280-311 hidden | 312-318 cut:5 | 319-325 cut:6 | 326-332 cut:7 | 333-1023 full:whatsaaaa | 1024-1400 full:/whatsaaaa 0.8.1: stubs(<5 chars) none on every page; 0.8.0: stubs on every page with a name longer than 1 charEvidence: Raw width sweep data
Evidence: Mobile-emulated and desktop measurements, both builds
0.8.0 300px / cut to 3 chars + ellipsis (whatsaaaa) 0.8.1 300px / hidden 0.8.0 320px /projects/form-builder/ cut to 6 chars + ellipsis 0.8.1 320px /projects/form-builder/ cut to 6 chars + ellipsis 0.8.1 1280px /projects/form-builder/ whole (~/projects/form-builder.md)Evidence: 0.8.1 production build log
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
pnpm install --frozen-lockfileresolves @whatsaaaa/design-system 0.8.1 andpnpm buildproduces the static sitepnpm install --frozen-lockfileprinted '+ @whatsaaaa/design-system 0.8.1';pnpm buildexit 0, 10 pages built (build-0.8.1.log); the built CSS carries the 0.8.1 thresholds calc(6ch + 1.75rem) / cal….logomargin removal do not apply).logorule or docs-theme import; built HTML differs from 0.8.0 only in the stylesheet hashpnpm install --frozen-lockfile(worktree, resolves @whatsaaaa/design-system 0.8.1)pnpm buildon 0.8.1 and on a disposable 0.8.0 baseline extracted from base commit 78a3d6f (both exit 0)astro previewof both builds on 127.0.0.1:4811 (0.8.1) and :4810 (0.8.0)Chrome for Testing 157 via chrome-devtools-axi: iframe width sweep 280-1400px (1px steps) across /, /projects/, /ideas/, /projects/form-builder/, /projects/building-blocks/, /ideas/react-component-library/, /404.html on both builds, recording if the status line path is hidden, whole, or cut to N characters plus an ellipsisMobile emulation (300x640, 320x568, 375x667 @2x, mobile and touch) plus 1280x800 desktop: measured the status line path on 5 pages per buildScreenshots of the status line at 300px and 320px on both builds, the 0.8.1 desktop window at 1280px, and the 0.8.1 tab bar at 300pxDiff of the built CSS and HTML between 0.8.0 and 0.8.1 buildsChecked src for.logoand docs-theme usage (none)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.
Visual diff: main vs this branch
I took screenshots of the home page and
/projects/design-system/on main and on this branch, in light and dark theme, at 320, 390 and 1440px, and pixel-diffed each pair. Only one change is visible, and it is the one 0.8.1 intends:w…; this branch hides the path.All other pairs are pixel-identical. In dark theme at 320px, both builds already show
whatsa…, because the shorter theme labelrose-pineleaves room for the path. No regressions.