-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Set version to 0.1.0 and add changelog #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4060d32
089b4c0
875fa0d
4e44af2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||||||||||||||||||||||||||||
| # Changelog | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| ## [0.1.0] - 2026-07-23 | ||||||||||||||||||||||||||||||||
| - Polymorphic form collection: a Form definition and its submissions, each scoped to any owning model via an owner morph | ||||||||||||||||||||||||||||||||
| - Public, throttled submission endpoint that resolves a form by key and records the submission | ||||||||||||||||||||||||||||||||
| - Pluggable, delivery-agnostic destinations (mail, webhook, Mautic, Smartpings) behind a destination contract, selectable per form | ||||||||||||||||||||||||||||||||
| - Spam protection: honeypot fields, a minimum submit time, and per-minute rate limiting | ||||||||||||||||||||||||||||||||
| - Typed submission columns (name, email, phone, subject, message) alongside an arbitrary payload, plus a delivery log | ||||||||||||||||||||||||||||||||
| - A FormSubmittedEvent the host can bridge to its own workflows | ||||||||||||||||||||||||||||||||
| - Config-driven throughout: destinations, protection thresholds, and the response formatter | ||||||||||||||||||||||||||||||||
|
Comment on lines
+4
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To follow the 'Keep a Changelog' standard, items should be grouped under category headings such as
Suggested change
|
||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,13 +12,13 @@ class MailDestination implements FormDestination | |||||
| { | ||||||
| public function deliver(FormSubmission $submission): void | ||||||
| { | ||||||
| $to = optional($submission->form)->recipient_email | ||||||
| $recipient = optional($submission->form)->recipient_email | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the project uses PHP 8.0+ features (like
Suggested change
|
||||||
| ?? config('eloquent-forms.mail.to'); | ||||||
|
|
||||||
| if (empty($to)) { | ||||||
| if (empty($recipient)) { | ||||||
| throw new RuntimeException('No recipient configured for the mail destination.'); | ||||||
| } | ||||||
|
|
||||||
| Mail::to($to)->send(new FormSubmissionReceived($submission)); | ||||||
| Mail::to($recipient)->send(new FormSubmissionReceived($submission)); | ||||||
| } | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ class SmartpingsDestination implements FormDestination | |||||
| public function deliver(FormSubmission $submission): void | ||||||
| { | ||||||
| throw new RuntimeException( | ||||||
| 'SmartPings destination is not implemented yet. Provide SMARTPINGS_CLIENT_ID and SMARTPINGS_SECRET_ID so it can be built on smartpings/php-sdk and tested.' | ||||||
| 'SmartPings destination is not implemented yet. Set SMARTPINGS_CLIENT_ID and SMARTPINGS_SECRET_ID before enabling it.' | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The updated error message implies that setting the environment variables is sufficient to enable the destination. However, the method remains unimplemented and will still throw a
Suggested change
|
||||||
| ); | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The year in the release date seems to be a future date (2026). Unless this is intentional, it is likely a typo and should be updated to reflect the actual release date.