chore: Update version and changelog - #22
Conversation
Code Review SummaryThe PR aims to release a new version of the package with Laravel 12 support. While the metadata updates are present, there are issues with the versioning strategy and a possible omission of dependency constraint updates. 🚀 Key Improvements
💡 Minor Suggestions
🚨 Critical Issues
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
9834378 to
98d53e2
Compare
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.2.1] - 2026-07-20 |
There was a problem hiding this comment.
The PR description indicates this is a 'minor release', which should increment the second digit (1.3.0). Incrementing the third digit (1.2.1) signifies a patch/bug-fix release. Furthermore, updating dependency support is typically categorized under ### Changed rather than ### Added.
| ## [1.2.1] - 2026-07-20 | |
| ## [1.3.0] - 2026-07-20 | |
| ### Changed |
| "type": "library", | ||
| "license": "proprietary", | ||
| "version": "1.2.0", | ||
| "version": "1.2.1", |
There was a problem hiding this comment.
Aligning with the 'minor release' intent and the addition of Laravel 12 support, the version should be bumped to 1.3.0 instead of 1.2.1.
| "version": "1.2.1", | |
| "version": "1.3.0", |
98d53e2 to
0b6cc7b
Compare
| ## [1.2.1] - 2026-07-20 | ||
|
|
||
| ### Changed | ||
| - Update composer.json to support Laravel 12 |
There was a problem hiding this comment.
Changelog entries are more effective when they describe the feature or compatibility added (e.g., 'Add support for Laravel 12') rather than the specific file modified. Additionally, ensure that the require section in composer.json is actually updated to include Laravel 12 constraints (e.g., ^12.0), as those changes are not visible in the current diff.
| - Update composer.json to support Laravel 12 | |
| - Add support for Laravel 12 |
2 participants
Update package version and changelog in preparation for a new minor release