Repository navigation
Fix WebP loading for transparent WebP - #35
Merged
Merged
Conversation
* While it seems that webp supports both premultiplied and unpremultiplied alpha channels it seems to me that in the real world it is premultiplied. Therefore also decode webp images as premultiplied images.
* Recreate the test data frame output of the webp animation as previously the webp images where premultiplied and saved as such even though PNG is always unpremultiplied. The difference between the images shows that the transparency looked wrong before as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it seems to me that in the real world it is premultiplied. Therefore also decode webp
images as premultiplied images.
On the WebP part I'm not 100% sure, but I did not find any webp where it was not premultiplied.
I also did premultiplication on PNG, but it seems that was already done by you a week ago :D
The tests I would need to check how we would fix those as they compare webp premultiplied with png non premultiplied, which fails ofc.Actually the tests where fine, but the Test Data was actually wrong, it is better visible on a dark background but can also be seen on github.