feat(web): complete the leading slash command with Tab in the composer - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tab in the composer now completes the highlighted leading
/command as plain text instead of the browser's focus walk: typing/go+ Tab fills/goalinto the draft, keeps focus, and runs nothing until Enter. Picking was deliberately avoided — the menu pick path executes bare (argument-less) commands immediately.Behavior
/+ highlighted candidate + Tab → splice/<name>over the token span (scopedslash/input-insert-text), close the menu, keep focus.@trigger) → Tab is consumed so focus cannot escape the composer.Changes
ArbitrateKeygainstab;InputTriggerController.arbitrateroutes tab to a newcomplete()arm.InputBar.onKeyDownintercepts Tab and preventDefaults whenever arbitration is notpass.Verification
test:guigreen (330 files / 4557 tests)doc-sync(28 gates) green