Release workflow: pin the driver by SHA-256, not Authenticode - #24
Merged
Conversation
The first dry run failed exactly where it should: upstream's setup wrapper (Virtual.Display.Driver-v25.05.03-setup-x64.exe) is unsigned — Get-AuthenticodeSignature reports NotSigned. The signed component is the driver package inside it, which Windows validates at install time, so a hard Authenticode gate on the wrapper can never pass. Replace it with the stronger check that does work: the workflow pins the vetted asset's SHA-256 (ca10b85b…) and hard-fails on mismatch, so a re-tagged or replaced upstream asset can't slip into a release. The Authenticode status is still reported informationally in case upstream starts signing. build-installer.ps1's -StrictSignature stays as a local knob for future signed drivers; CI no longer passes it. DECISIONS.md and the vendor README now describe the real scheme (the old README wrongly promised the wrapper would verify as Valid).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first release dry run (run 32994199993) failed at the driver-signature gate — correctly, because upstream's setup wrapper is genuinely unsigned (
NotSigned). The signed component is the driver package inside, which Windows itself validates at install time; a hard Authenticode gate on the wrapper can never pass.This replaces it with the check that's actually stronger for supply-chain pinning: the workflow verifies the vetted asset's SHA-256 (
ca10b85b…, matching the 5,516,873-byte asset on the 25.5.2 tag) and hard-fails on mismatch, so a re-tagged or replaced upstream asset can't slip into a release. Authenticode status is still reported informationally in case upstream starts signing. DECISIONS.md and the vendor README now describe the real scheme, andbuild-installer.ps1 -StrictSignaturestays as a local knob for future signed drivers.After merge: re-dispatch the release.yml dry run to validate the whole pipeline.