Skip to content

refactor: move route plugins to Nova global config #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taure merged 1 commit into from
Apr 9, 2026
Merged

refactor: move route plugins to Nova global config #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions config/dev_sys.config.src
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,19 @@
}},
{dev_mode, true},
{bootstrap_application, asobi},
{json_lib, json}
{json_lib, json},
{plugins, [
{pre_request, nova_request_plugin, #{
decode_json_body => true,
parse_qs => true
}},
{pre_request, nova_cors_plugin, #{
allow_origins => ~"*"
}},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, asobi_rate_limit_plugin, #{limiter => asobi_api_limiter}},
{post_request, asobi_security_headers_plugin, #{}}
]}
]},
{kura, [
{repo, asobi_repo},
Expand All @@ -37,16 +49,6 @@
]},
{asobi, [
{nova_apps, [nova_resilience]},
{plugins, [
{pre_request, nova_request_plugin, #{
decode_json_body => true,
parse_qs => true
}},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, nova_cors_plugin, #{
allow_origins => <<"*">>
}}
]},
{game_modes, #{
%% Map mode names to game behaviour modules
%% ~"default" => my_game_module
Expand Down
24 changes: 13 additions & 11 deletions config/prod_sys.config.src
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,19 @@
}},
{dev_mode, false},
{bootstrap_application, asobi},
{json_lib, json}
{json_lib, json},
{plugins, [
{pre_request, nova_request_plugin, #{
decode_json_body => true,
parse_qs => true
}},
{pre_request, nova_cors_plugin, #{
allow_origins => <<"${ASOBI_CORS_ORIGINS}">>
}},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, asobi_rate_limit_plugin, #{limiter => asobi_api_limiter}},
{post_request, asobi_security_headers_plugin, #{}}
]}
]},
{kura, [
{repo, asobi_repo},
Expand All @@ -35,16 +47,6 @@
{asobi, [
{game_dir, "/app/game"},
{nova_apps, [nova_resilience]},
{plugins, [
{pre_request, nova_request_plugin, #{
decode_json_body => true,
parse_qs => true
}},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, nova_cors_plugin, #{
allow_origins => <<"${ASOBI_CORS_ORIGINS}">>
}}
]},
{matchmaker, #{
tick_interval => 1000,
max_wait_seconds => 60
Expand Down
43 changes: 3 additions & 40 deletions src/asobi_router.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,30 +12,10 @@ routes(_Environment) ->
ws_routes()
].

cors_opts() ->
Origins = application:get_env(asobi, cors_allow_origins, ~""),
#{allow_origins => Origins}.

rate_limit_opts(Group) ->
#{limiter => limiter_name(Group)}.

limiter_name(auth) -> asobi_auth_limiter;
limiter_name(iap) -> asobi_iap_limiter;
limiter_name(api) -> asobi_api_limiter.

auth_routes() ->
#{
prefix => ~"/api/v1/auth",
security => false,
plugins => [
{pre_request, nova_request_plugin, #{
decode_json_body => true
}},
{pre_request, nova_cors_plugin, cors_opts()},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, asobi_rate_limit_plugin, rate_limit_opts(auth)},
{post_request, asobi_security_headers_plugin, #{}}
],
routes => [
{~"/register", fun asobi_auth_controller:register/1, #{methods => [post]}},
{~"/login", fun asobi_auth_controller:login/1, #{methods => [post]}},
Expand All @@ -48,15 +28,6 @@ iap_routes() ->
#{
prefix => ~"/api/v1/iap",
security => fun asobi_auth_plugin:verify/1,
plugins => [
{pre_request, nova_request_plugin, #{
decode_json_body => true
}},
{pre_request, nova_cors_plugin, cors_opts()},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, asobi_rate_limit_plugin, rate_limit_opts(iap)},
{post_request, asobi_security_headers_plugin, #{}}
],
routes => [
{~"/apple", fun asobi_iap_controller:verify_apple/1, #{methods => [post]}},
{~"/google", fun asobi_iap_controller:verify_google/1, #{methods => [post]}}
Expand All @@ -67,16 +38,6 @@ api_routes() ->
#{
prefix => ~"/api/v1",
security => fun asobi_auth_plugin:verify/1,
plugins => [
{pre_request, nova_request_plugin, #{
decode_json_body => true,
parse_qs => true
}},
{pre_request, nova_cors_plugin, cors_opts()},
{pre_request, nova_correlation_plugin, #{}},
{pre_request, asobi_rate_limit_plugin, rate_limit_opts(api)},
{post_request, asobi_security_headers_plugin, #{}}
],
routes => [
%% Auth - Provider linking
{~"/auth/link", fun asobi_oauth_controller:link/1, #{methods => [post]}},
Expand Down Expand Up @@ -139,7 +100,9 @@ api_routes() ->
{~"/groups/:id", fun asobi_social_controller:update_group/1, #{methods => [put]}},
{~"/groups/:id/join", fun asobi_social_controller:join_group/1, #{methods => [post]}},
{~"/groups/:id/leave", fun asobi_social_controller:leave_group/1, #{methods => [post]}},
{~"/groups/:id/members", fun asobi_social_controller:list_members/1, #{methods => [get]}},
{~"/groups/:id/members", fun asobi_social_controller:list_members/1, #{
methods => [get]
}},
{
~"/groups/:id/members/:player_id/role",
fun asobi_social_controller:update_member_role/1,
Expand Down
Loading