Fix confirmation window for adding oldrfd to redirects#145
Open
Trialpearswiki wants to merge 1 commit into
Open
Fix confirmation window for adding oldrfd to redirects#145Trialpearswiki wants to merge 1 commit into
Trialpearswiki wants to merge 1 commit into
Conversation
Trialpearswiki
changed the title
Trialpearswiki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97 which in reality was triggered by trying to place the oldrfd template on a talk page which was a redirect itself. There was code for handling this using OO.ui.confirm to ask the user but it was broken. Switching to multiButtonConfirm like similar confirmations are done solved the issue.