Improved queries for finding pages involved in CfD#147
Open
Trialpearswiki wants to merge 4 commits into
Open
Conversation
Trialpearswiki
changed the title
Author
|
I don't believe I'm able to link the other two issues to this pull request myself but that should be done. |
TP, I believe if you change your opening statement to "Resolves X, Resolves Y, Resolves Z" it should link them all; git needs explicit linking phrases for each one. |
Author
|
That did the trick, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #80, resolves #78, resolves #73 all of which stem from the detection of which pages are nominated being severely broken.
The detection algorithm consist of two parts one for detecting nomination without a template and a second for nomination using a template. The former was overly strict requiring the action to be preceded by "Propose" which caused many nominations to use the way too loose second query. (#78 and #80) By requiring the link to be the second child we ensure we don't include spurious merge targets as before even if there's a mix of links with and without spans.
Testing was done mostly by checking that all 28 discussions posted yesterday parsed correctly which wasn't the case with the old detection system at all.