Skip to content

fix(acp): distinguish intentional child shutdown (#20) - #40

Merged
willgriffin merged 12 commits into
masterfrom
codex/issue-20-intentional-exit
Aug 11, 2026
Merged

willgriffin merged 12 commits into
masterfrom
codex/issue-20-intentional-exit

Conversation

@willgriffin

Copy link
Copy Markdown
Owner

Closes #20

Summary

Suppresses crash telemetry for intentional clean child shutdown while retaining unexpected clean exits, nonzero exits, and signals as observable failures. Canonical integration will preserve the exact reviewed commits in the Wave 1 branch; this GitHub PR is the lifecycle and CI mirror.

Validation

  • ACP multiplexer focused tests
  • cancellation contract repeated passes
  • typecheck, lint, format, build
  • Terra exact-SHA reviews

Drive-by fixes

  • 422e4100c1680e16d6790398b83fcb3fe25dde59: await cancelled prompt responses so the contract test does not create an unhandled rejection
  • 9df4da8e43cf7bce370df0c30a5f4f0e6b191eae: preserve response-queue ordering after Terra found a drain race

Blocked review gate

Mandatory local Claude/Fable exact-SHA review is pending because the organization disabled Claude subscription access for Claude Code. The branch remains ready for review but must not be integrated until access is restored and the exact commits pass Fable review.

{"schema":"hv-agent-run:v1","runtime":"codex","session":"codex-epic-1-wave1","issue":"20","policy_revision":"1.0.0","validation":["ACP multiplexer focused tests","cancellation contract repeated passes","typecheck lint format build","Terra exact-SHA reviews","Fable exact-SHA review pending external access"]}

Will Griffin added 12 commits August 10, 2026 08:23
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
Signed-off-by: Will Griffin <will@griffn.ca>
@willgriffin willgriffin added the status: blocked Reviewable but blocked from merge label Aug 10, 2026
@willgriffin

Copy link
Copy Markdown
Owner Author

Mandatory Claude/Fable exact-SHA review unavailable: organization disabled Claude subscription access for Claude Code after three retries; next: re-enable Claude Code subscription access or configure ANTHROPIC_API_KEY locally, then review 422e410 and 9df4da8 before integration.

@willgriffin willgriffin removed the status: blocked Reviewable but blocked from merge label Aug 11, 2026
@willgriffin
willgriffin merged commit 1ccb4f0 into master Aug 11, 2026
3 of 5 checks passed
@willgriffin
willgriffin deleted the codex/issue-20-intentional-exit branch August 11, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2][Core] Do not report intentional session close as a child crash

1 participant