fix: always replay the current todo list on session/load - #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A re-attaching client (the mobile app always re-attaches via
session/load) never learned a session's current todo list: the sharedper-session differ only emits
PlanUpdateon plan CHANGE, and itslastPlanSigwas already aligned by whatever client attached first —the second load's diff came back empty.
Fix
effect (turn completion must not re-emit replayed history), but
discard its events.
"__none__"sentinel makesdiffPlanalways fire — every load nowcarries the plan, changed or not.
Testing
tests/load-plan-replay.test.ts: a secondloadSessionon the samesession still emits a PlanUpdate with the current entries. Verified to
fail without the fix (stash → red, pop → green).