Skip to content

Remove leftover debugger() statements #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fpauser wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove leftover debugger() statements #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8bc99
Remove leftover `debugger()` statements
fpauser Jan 15, 2020
7eb0c84
Log unknown tags with debug()
fpauser Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

var logUnknownTag = require('debug')('ipp:unknown-tag');

var enums = require('./enums'),
operations = enums['operations-supported'],
Expand Down Expand Up @@ -129,7 +129,6 @@ module.exports = function(buf) {

case tags['no-value']:
default:
debugger;
return module.exports.handleUnknownTag(tag, name, length, read)
}
}
Expand Down Expand Up @@ -190,7 +189,7 @@ module.exports = function(buf) {
};
module.exports.handleUnknownTag = function log(tag, name, length, read) {
var value = length? read(length) : undefined;
console.log("The spec is not clear on how to handle tag " +tag+ ": " +name+ "=" +String(value)+ ". " +
logUnknownTag("The spec is not clear on how to handle tag " +tag+ ": " +name+ "=" +String(value)+ ". " +
"Please open a github issue to help find a solution!");
return value;
};
1 change: 0 additions & 1 deletion lib/serializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ module.exports = function serializer(msg){
return write2(0);

default:
debugger;
console.error(tag, "not handled");
}
}
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"name": "William Kapke",
"email": "william.kapke@gmail.com"
},
"dependencies": {
"debug": "^4.1.1"
},
"devDependencies": {
"concat-stream": "^1.6.0",
"mdns": "^2.3.3",
Expand Down