Repository navigation
Add Session.TxResults - #22
Merged
Merged
Conversation
Session.TxResults returns how the application transactions of every *sql.DB of the session ended, in order, so that a test can check that the code under test committed or rolled back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 91.92% 92.44% +0.51%
==========================================
Files 6 6
Lines 322 344 +22
==========================================
+ Hits 296 318 +22
Misses 14 14
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session.TxResults, which returns how the application transactions of every*sql.DBof the session ended, in order. It records outcomes rather than calls, sotx.Rollback()afterCommitis not counted.TxCommitted:Commitsucceeded.TxRolledBack:Rollbackwas called, or the transaction's context was canceled.TxCommitFailed:Commitwas called but did not commit, such as when the transaction had hit an error.TxResultsdoes not wait for the session, so it can be called while a transaction is open. A transaction that is still open is not included.database/sqlrolls back a canceled transaction in another goroutine, so its result may appear shortly after the cancellation. This comes from readingdatabase/sql; the test waits withassert.Eventuallyand does not reproduce the delay itself.Test plan
make vetgo test -race -count=1 ./...go test -race -count=20 -run 'TestTxResults|TestTxResultString' ./...golangci-lint run