Repository navigation
Add Register and Lookup - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 92.44% 92.75% +0.31%
==========================================
Files 6 7 +1
Lines 344 359 +15
==========================================
+ Hits 318 333 +15
Misses 14 14
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register, which makes a*Sandpitavailable under a name, andLookup, which returns it, so that tests can choose a database by name.Registertakes a*Sandpitrather than a DSN, so one made withNewWithConfigcan be registered too, andWith()works on whatLookupreturns.Registerpanics on a nilSandpitor a name that is already registered, andLookuppanics on an unknown name.RegisterandLookupare safe for concurrent use.Each test package runs in its own process, so the registrations are shared by a package that registers them in
init, not by the registry itself.There is no function to close every registered
Sandpit.Lookup(name).Close()closes one.Test plan
make vetgo test -race -count=1 ./...go test -race -count=20 -run 'TestRegister|TestLookup' ./...golangci-lint run