Repository navigation
Add SessionBuilder.Cache - #24
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 92.75% 93.08% +0.32%
==========================================
Files 7 7
Lines 359 376 +17
==========================================
+ Hits 333 350 +17
Misses 14 14
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionBuilder.Cache, which makesSessionreturn the session cached fortif there is one, and otherwise open one and cache it untiltand its subtests finish. Helpers can get the session fromtalone.Sandpit, so separateWith().Cache()calls on oneSandpitshare it.Cacheare neither read from nor added to the cache, sosandpit.Session(t)still opens a new session each time.t, so it gets its own session rather than its parent's.topen one session. If opening it fails the test, the other calls fail the test too instead of returning nil.Test plan
make vetgo test -race -count=1 ./...go test -race -count=20 -run 'TestCache' ./...golangci-lint run