Skip to content

Stop passing *testing.T to the Connector functions - #27

Merged
winebarrel merged 1 commit into
mainfrom
revert-connector-testing-t
Nov 8, 2026
Merged

winebarrel merged 1 commit into
mainfrom
revert-connector-testing-t

Conversation

@winebarrel

Copy link
Copy Markdown
Owner

Summary

Test plan

  • go vet ./...
  • make test (go test -v -race -count=1 ./...)
  • golangci-lint run

Restore the signatures of DBBuilder.Connector and SessionBuilder.Connector
to what they were before #26. The functions given to Conn still take
*testing.T.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@winebarrel
winebarrel enabled auto-merge November 8, 2026 12:15
@winebarrel
winebarrel merged commit 2ca3dac into main Nov 8, 2026
2 checks passed
@winebarrel
winebarrel deleted the revert-connector-testing-t branch November 8, 2026 12:16
@codecov

codecov Bot commented Nov 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (61c017e) to head (ab4d17f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files           7        7           
  Lines         425      425           
=======================================
  Hits          393      393           
  Misses         17       17           
  Partials       15       15           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant