Update GTK to version 4.20.1

[Beryesa]

Hi, a new stable gtk release in town :P
Probably other libs will also need updates, but I haven't messed with the appstream patch for libadwaita 1.8 etc

There's also the shadow issues again but I'm not sure if it's an upstream regression or renderer misconfiguration;
haven't got 4.20.1 over the msys2 packages to check against that yet

Marking as Draft

[danyeaw]

Hey @Beryesa - thanks so much for the contribution! You'll need to update libadwaita as well with the same PR I think.

[Beryesa]

Thanks, will get on it
Btw what do you think about the possibility to patch appstream to build instead of stripping it out of libadwaita?
Based on this ximion/appstream#541

[danyeaw]

Hi @Beryesa, I would be ok with patching Appstream instead of libadwaita if someone can get it to build. I have no idea what is required to get clang set up.

[danyeaw]

Hi @Beryesa, I repatched libadwaita and pushed it to your branch. Are you good for us to merge this?

[Beryesa]

Oh, sure of course, thanks, take it as you wish – I didn't have the chance over the weekend. 😅

[lazka]

related: msys2/MINGW-packages#25319 has two patches which fixes rendering, but videos are broken (and maybe more?)

[danyeaw]

Current issue is building libadwaita on CI:

FAILED: [code=1] src/adw-resources.c 
"C:/gtk-build/gtk/x64/release/bin/../bin\glib-compile-resources.EXE" "../src/adwaita.gresources.xml" "--sourcedir" "C:/gtk-build/build/x64/release/libadwaita/src" "--sourcedir" "../src" "--c-name" "adw" "--internal" "--generate" "--target" "src/adw-resources.c" "--dependency-file" "src/adw-resources.c.d"
../src/adwaita.gresources.xml: Child process exited with code -1073740791.

It passes locally though. Maybe some type of issue with the stack size of glib-compile-resources.

[Beryesa]

Couldn't we ifdef it in the upstream about-dialog etc instead of patching it manually every time? It has some checks for macos elsewhere.

[danyeaw]

Unfortunately libadwaita has not been willing to accept such a patch, see:
https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/895

https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/833

https://gitlab.gnome.org/GNOME/libadwaita/-/issues/777

I'm not sure why we are getting CI failures of the build, but libadwaita builds fine locally.

[danyeaw]

Hi @Beryesa, I broke this PR apart in to multiple steps to help resolve the issues: #1674, #1675, #1680. Thanks for helping to get this started! I'm going to go ahead and close this one.

[Beryesa]

Not that I did anything useful, it was far more involved than I had anticipated, so thanks for handling it properly 🩵

[danyeaw]

This ended up being a particularly challenging version update! Normal updates are bump the version and hash, so definitely feel free to contribute updates in the future, they are really appreciated.