revert(text): restore Atkinson Hyperlegible Next as sans-serif default - #38
Merged
Conversation
…fault Hanken Grotesk (#37) read as flatter in practice — Atkinson Hyperlegible Next has more character, so restore it as the built-in sans-serif stack. The configureFonts() API from #37 stays; only the default face changes, so anyone who wants Hanken Grotesk can still opt in via configureFonts. Playground font link + the default-stack test updated to match.
…ples Revert #38 removed Hanken Grotesk from the codebase; the override examples in the README + configureFonts/FontConfig doc-comments still referenced it, which read as a stray leftover. Use Inter as a neutral example font.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing the Hanken Grotesk default from #37, Atkinson Hyperlegible Next reads with more character, so this restores it as the built-in
sans-serifstack.Changes
packages/core/src/text/defaults.ts—DEFAULT_FONT_STACKS['sans-serif']back to Atkinson Hyperlegible Next (generic fallbacks unchanged).examples/playground/index.html— Google Fonts<link>loads Atkinson again.packages/core/tests/font-config.test.ts— default-stack assertions updated.What's not reverted
The
configureFonts()runtime API from #37 stays. Only the default face changes — anyone who prefers Hanken Grotesk can still opt in:(That's still the illustrative example in the docs.)
Full core suite (359 unit), lint, typecheck pass.