call fs.close synchronously - #1022
Closed
thefourtheye wants to merge 1 commit into
Closed
thefourtheye wants to merge 1 commit into
thefourtheye wants to merge 1 commit into
Conversation
As nodejs/node#12562 landed in Node.js, `fs.close` call without callback function will fail in Node.js v8.
|
Is this the right substitute though? It seems like async methods are being used there, so maybe at least an empty callback should be used instead (or better yet do something in case of error)? |
Member
|
Thanks for the insights @mscdex – will keep an eye on this and perhaps land it in the |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As nodejs/node#12562 landed in Node.js,
fs.closecall without callback function will fail in Node.js v8.