Conversation
Collaborator
|
Hey @tdumalin, thanks a lot for your contribution! I would need to sit into how to properly solve it here. Also, such code would require to be available only with PHP8.1 enabled |
Author
|
Yes indeed, I've seen the build errors and parseError could not be avoided in php < 8.1. The only solution would be to add php version in composer.json but it will be very tricky to manage. |
Contributor
|
Hey! What do you guys think about skipping these tests for PHP <8.1? Skipping examples can be used for that: if (version_compare(PHP_VERSION, '8.1.0', '<')) {
throw new \PhpSpec\Exception\Example\SkippingException('Requires at least PHP 8.1.');
} |
Author
|
@coldic3 , |
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
Co-authored-by: Kevin Kaniaburka <kevin.kaniaburka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've created an issue on StateMachineBundle (#70) but i realized that it's on this repo that we have to work.
So this is an implementation for php8.1 enum support, let me know what do you think.