WPB-26637: Fix ecall balance#182
Open
sifa-wire wants to merge 1 commit into
Open
Conversation
|
z-dule
approved these changes
Jul 3, 2026
z-dule
left a comment
z-dule
left a comment
Contributor
There was a problem hiding this comment.
Looks good, this is what we discussed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
This pr aims to fix reference count on ecall obj.
we call wcall destructor indirectly here
wire-avs/src/ccall/ccall.c
Line 1111 in 5a8cfb6
which destructs ecall. then
it is dereferenced one more here
wire-avs/src/ccall/ccall.c
Line 1129 in 5a8cfb6