Skip to content

feat: Added the ablity to select target architecture for linux builds #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-lisa wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: Added the ablity to select target architecture for linux builds #8294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,17 @@ export ENABLE_ASAR="false"
yarn build:linux
```

### Other architectures

To build for another architecture such as `arm64` run the following command:

```shell
export ARCH=<target>
yarn build:linux
```

Replace `<target>` with your desired target (e.g. `arm64`). Have a look at the [documentation for `electron-builder`](https://www.electron.build/electron-builder.enumeration.arch) for the available target architectures. Only one architecture may be specified at a time.

### Troubleshooting

If you are having troubles building Wire for Desktop, then [our troubleshooting page](https://github.com/wireapp/wire-desktop/wiki/Troubleshooting) might be of help.
Expand Down
10 changes: 9 additions & 1 deletion bin/build-tools/lib/build-linux.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,15 @@ export async function buildLinuxWrapper(
packageJsonPath: string,
wireJsonPath: string,
envFilePath: string,
architecture: electronBuilder.Arch = electronBuilder.Arch.x64,
architecture: electronBuilder.Arch = (() => {
const archMap: { [key: string]: electronBuilder.Arch } = {
'arm64': electronBuilder.Arch.arm64,
'armv7l': electronBuilder.Arch.armv7l,
'ia32': electronBuilder.Arch.ia32,
'x64': electronBuilder.Arch.x64
};
return archMap[process.env.ARCH?.toLowerCase() || 'x64'];
})(),
): Promise<void> {
const wireJsonResolved = path.resolve(wireJsonPath);
const packageJsonResolved = path.resolve(packageJsonPath);
Expand Down