Skip to content

Add support for nodePort on service#61

Merged
gitkent merged 2 commits intowiremock:masterfrom
kurtnapolitano:patch-1
Jun 16, 2025
Merged

Add support for nodePort on service#61
gitkent merged 2 commits intowiremock:masterfrom
kurtnapolitano:patch-1

Conversation

@kurtnapolitano
Copy link
Copy Markdown
Contributor

@kurtnapolitano kurtnapolitano commented Jun 4, 2025

When using a service type of NodePort, the port you wish to expose must be specified under the .spec.ports[*].nodePort entry.

https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

When using a service type of `NodePort`, the port you wish to expose must be specified under the `.spec.ports[*].nodePort` entry.

https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport
@kurtnapolitano kurtnapolitano requested a review from gitkent as a code owner June 4, 2025 20:19
@gitkent
Copy link
Copy Markdown
Collaborator

gitkent commented Jun 12, 2025

@kurtnapolitano please check failed ci build.

@kurtnapolitano
Copy link
Copy Markdown
Contributor Author

@gitkent , updated helm chart number with a minor version rev (supporting nodeport feels like a feature-add), linter should pass now.

@gitkent gitkent merged commit b1d5674 into wiremock:master Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants