Skip to content

feat: add option to configure ressource requests und limits on init containers#63

Merged
gitkent merged 1 commit intowiremock:masterfrom
sam0r040:add_option_to_configure_ressources_for_init_containers
Aug 25, 2025
Merged

feat: add option to configure ressource requests und limits on init containers#63
gitkent merged 1 commit intowiremock:masterfrom
sam0r040:add_option_to_configure_ressources_for_init_containers

Conversation

@sam0r040
Copy link
Copy Markdown
Contributor

This PR adds the option initContainer.resources to configure resource requests and limits for the init containers. This is necessary in environments that require resource limits to be set for all containers.

All pre-defined init containers receive the same configuration as there is no specific configuration yet and both are basically performing the same task.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@sam0r040 sam0r040 requested a review from gitkent as a code owner June 25, 2025 08:46
@sam0r040 sam0r040 force-pushed the add_option_to_configure_ressources_for_init_containers branch from a2c4387 to 88e5070 Compare July 2, 2025 15:13
@sam0r040
Copy link
Copy Markdown
Contributor Author

sam0r040 commented Jul 2, 2025

@gitkent I was not aware that I should increase the chart version as part of the PR and increased it just now. Is there anything else I can do to move this forward?

@gitkent
Copy link
Copy Markdown
Collaborator

gitkent commented Jul 15, 2025

@gitkent I was not aware that I should increase the chart version as part of the PR and increased it just now. Is there anything else I can do to move this forward?

@sam0r040 no worries. Can you please check the CI build again? It failed on linting.

@sam0r040 sam0r040 force-pushed the add_option_to_configure_ressources_for_init_containers branch from 88e5070 to 616a777 Compare August 22, 2025 15:02
@gitkent gitkent merged commit b93b7bd into wiremock:master Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants