Open
Conversation
sgunes-wirepas
approved these changes
Jan 19, 2026
GwendalRaoul
commented
Jan 19, 2026
lib/api/wpc_proto.h
Outdated
| * wp_UploadScratchpadResp_size | ||
| */ | ||
| #define WPC_PROTO_MAX_RESPONSE_SIZE (415 + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD) | ||
| #define WPC_PROTO_MAX_RESPONSE_SIZE (450 + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD) |
Contributor
Author
There was a problem hiding this comment.
We should find a way to size it.
I added some bytes to take into account flags support.
Contributor
There was a problem hiding this comment.
Might be good to have a comment telling where this number comes from
GwendalRaoul
commented
Jan 19, 2026
| char * gateway_version, | ||
| char * sink_id) | ||
| { | ||
| _Static_assert(WPC_PROTO_MAX_RESPONSE_SIZE >= (wp_GetConfigsResp_size + WPC_PROTO_GENERIC_MESSAGE_OVERHEAD), |
Contributor
Author
There was a problem hiding this comment.
It is removed on purpose as now wp_GetConfigsResp_size is not available in generated code
It will avoid dynamic size
GwendalRaoul
force-pushed
the
update_proto/support_virtual_node_flag
branch
from
3a4295a to
eb26798
Compare
Contributor
Author
|
Initially I forget the options we use to generate "static" c code rather than runtime dynamic code. |
sgunes-wirepas
approved these changes
Jan 20, 2026
StephaneTriomphe
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.