Repository navigation
Compare the SDK contract with the latest release branch - #169
Merged
Merged
Conversation
The weekly drift check checked out the SDK default branch, so unreleased header changes failed the wiresock-sdk-contract deployment. Resolve the highest release/vMAJOR.MINOR.PATCH branch and compare that tip instead.
wiresock
commented
Nov 4, 2026
Branch pages were returned with return @(), which enumerates the elements and turns a missing page into null. Emit each page as one array object, and keep a bare branch for the one-element unwrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly
wiresock-sdk-contractdeployment checked outWiresock-Foundation/wiresock-vpn-clientwith no ref, so it followed the default branch. That branch now carries unreleased AmneziaWG 3.x and randomized-keepalive APIs (wgb_create_tunnel_ex2/_ex3). The pinnedwgbooster.hfailed the drift check even though those APIs are not on a release branch.Resolve-SdkReleaseBranch.ps1lists the SDK repository's branches, keeps names that matchrelease/vMAJOR.MINOR.PATCH, and selects the highest version. The drift job checks out that branch and stops unless the checkout is the commit the resolver recorded. Prerelease names, partial versions, and leading zeros are ignored. A moved or non-canonical result fails closed.On the current SDK repository this resolves to
release/v3.8.2(1dfbf801f0eddec32c5efb69c6efdd203ee93c70).The next scheduled run still fails, for a smaller difference on that release branch.
include/wgbooster.hadds documentation forendpoint_resolution_cacheonwgb_set_global_option.wgbooster.defmatches the pin. Accepting that comment is a separate, explicit contract update.Tests
scripts/Resolve-SdkReleaseBranch.Tests.ps1scripts/Test-WorkflowSecurity.Tests.ps1scripts/Test-WorkflowSecurity.ps1Wiresock-Foundation/wiresock-vpn-client, which selectedrelease/v3.8.2