feat(ai): stream reasoning preview in ai ask#14
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds real-time streaming of AI reasoning/thinking preview during dub ai ask commands, improving user experience by showing what the AI is considering. It also enhances command history capture to filter out carriage-return based progress indicators (like spinners) to keep history clean.
Changes:
- Modified AI streaming to use
fullStreamAPI instead oftextStream, handling reasoning events (reasoning-start/delta/end) alongside text output - Added TTY-aware thinking renderer that displays a spinner with reasoning preview when output is interactive
- Added
normalizeHistoryLinefunction to filter carriage-return output from command history
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/ai.ts | Added WritableLike.isTTY property, updated THINKING_PROVIDER_OPTIONS to include thoughts, switched from textStream to fullStream with event-based handling, added createThinkingRenderer for TTY spinner display |
| src/commands/ai.test.ts | Updated test helpers to support fullStream API, added tests for TTY thinking preview and error stream events |
| src/index.ts | Added normalizeHistoryLine function to filter carriage-return output from history capture, integrated normalization into captureLine |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 DubStack