Conversation
* ci: hard-reset main from upstream Co-authored-by: William Feht <wmfeht@users.noreply.github.com> * ci: use git reset --hard for upstream sync Co-authored-by: William Feht <wmfeht@users.noreply.github.com> --------- Co-authored-by: William Feht <4131301+wmfeht@users.noreply.github.com> Co-authored-by: William Feht <wmfeht@users.noreply.github.com>
The Cloud Agent install was baking tests/e2e/Dockerfile with context tests/e2e. After the pinned-package recipe, COPY tests/e2e/install-packages.sh needs the checkout root, and RUN --mount needs BuildKit. Fail docker builds before the legacy builder, and document the Cloud Agent pitfall. Co-authored-by: wmfeht <wmfeht@proton.me>
Snapshot restore leaves docker.pid files that block dockerd. The Cloud Agent venv lives at target/e2e-venv from install, not /opt. Co-authored-by: wmfeht <wmfeht@proton.me>
wmfeht
marked this pull request as ready for review
September 12, 2026 23:47
github-actions
Bot
force-pushed
the
main
branch
17 times, most recently
from
September 19, 2026 20:48
52aef90 to
51fba50
Compare
github-actions
Bot
force-pushed
the
main
branch
from
September 20, 2026 05:00
51fba50 to
b415eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recurring Cloud Agent environment builds fail in
installbecause the saved script still runsdocker build -f tests/e2e/Dockerfile tests/e2e. That matched the old recipe (COPY requirements.txtfrom thetests/e2edirectory). The current Dockerfile copiestests/e2e/install-packages.shfrom the checkout root and uses BuildKitRUN --mount.This change:
python3 scripts/e2e_base.py buildrefuse Docker without thedocker-buildxplugin, before the legacy builder starts..cursor/CLOUD.md: do not bake the E2E image duringinstall, never usetests/e2eas the build context, andstartmust drop staledocker.pid/ containerd pid files after snapshot restore.The dashboard
install/startscripts are a saved-environment change, not this branch. Drop thedocker build. Keep host GTK, Rust, andtarget/e2e-venv. Havestartremove leftover Docker pid files before launchingdockerd. Tested draft build: bld-20260912-b08a443a-17c9-401f-a8c0-a465d6b5d524.Visual evidence
N/A — Cloud Agent install/docs and E2E base-image helper, not a GUI change.
How to test
docker-buildx, runpython3 scripts/e2e_base.py build --engine docker.COPY tests/e2e/install-packages.shfailing.python3 scripts/test_e2e_base.py.Expected result: Docker builds without BuildKit fail fast. Podman builds are unchanged. Cloud Agent
installno longer needs to baketests/e2e/Dockerfile. After Save,startbrings Docker up on a restored snapshot.Related issue
Issues are disabled on
wmfeht/strata. Failed build: bld-20260912-8c654577-bed0-4530-9716-48e23e0cb3ee.