Skip to content

fix(e2e): require BuildKit and repo-root context for Docker base builds - #27

Open
wmfeht wants to merge 3 commits into
mainfrom
cursor/cloud-e2e-install-e687
Open

wmfeht wants to merge 3 commits into
mainfrom
cursor/cloud-e2e-install-e687

Conversation

@wmfeht

@wmfeht wmfeht commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Description

Recurring Cloud Agent environment builds fail in install because the saved script still runs docker build -f tests/e2e/Dockerfile tests/e2e. That matched the old recipe (COPY requirements.txt from the tests/e2e directory). The current Dockerfile copies tests/e2e/install-packages.sh from the checkout root and uses BuildKit RUN --mount.

This change:

  • Makes python3 scripts/e2e_base.py build refuse Docker without the docker-buildx plugin, before the legacy builder starts.
  • Documents the Cloud Agent pitfall in .cursor/CLOUD.md: do not bake the E2E image during install, never use tests/e2e as the build context, and start must drop stale docker.pid / containerd pid files after snapshot restore.

The dashboard install / start scripts are a saved-environment change, not this branch. Drop the docker build. Keep host GTK, Rust, and target/e2e-venv. Have start remove leftover Docker pid files before launching dockerd. Tested draft build: bld-20260912-b08a443a-17c9-401f-a8c0-a465d6b5d524.

Visual evidence

N/A — Cloud Agent install/docs and E2E base-image helper, not a GUI change.

How to test

  1. On a host without docker-buildx, run python3 scripts/e2e_base.py build --engine docker.
  2. Confirm it exits immediately with a BuildKit / repository-root context error instead of COPY tests/e2e/install-packages.sh failing.
  3. Run python3 scripts/test_e2e_base.py.

Expected result: Docker builds without BuildKit fail fast. Podman builds are unchanged. Cloud Agent install no longer needs to bake tests/e2e/Dockerfile. After Save, start brings Docker up on a restored snapshot.

Related issue

Issues are disabled on wmfeht/strata. Failed build: bld-20260912-8c654577-bed0-4530-9716-48e23e0cb3ee.

Open in Web Open in Cursor 

wmfeht and others added 3 commits September 11, 2026 19:34
* ci: hard-reset main from upstream

Co-authored-by: William Feht <wmfeht@users.noreply.github.com>

* ci: use git reset --hard for upstream sync

Co-authored-by: William Feht <wmfeht@users.noreply.github.com>

---------

Co-authored-by: William Feht <4131301+wmfeht@users.noreply.github.com>
Co-authored-by: William Feht <wmfeht@users.noreply.github.com>
The Cloud Agent install was baking tests/e2e/Dockerfile with context
tests/e2e. After the pinned-package recipe, COPY tests/e2e/install-packages.sh
needs the checkout root, and RUN --mount needs BuildKit. Fail docker
builds before the legacy builder, and document the Cloud Agent pitfall.

Co-authored-by: wmfeht <wmfeht@proton.me>
Snapshot restore leaves docker.pid files that block dockerd. The
Cloud Agent venv lives at target/e2e-venv from install, not /opt.

Co-authored-by: wmfeht <wmfeht@proton.me>
@wmfeht
wmfeht marked this pull request as ready for review September 12, 2026 23:47
@github-actions
github-actions Bot force-pushed the main branch 17 times, most recently from 52aef90 to 51fba50 Compare September 19, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants