Conversation
wmfeht
force-pushed
the
fix/854-permanent-delete-enter
branch
from
September 16, 2026 00:00
6c28859 to
db3fda5
Compare
Permanent-delete confirmation always activated confirm on Enter, even after focus moved to Cancel. Activate the focused button instead, matching paste and archive conflict dialogs. Confirm stays the initial focus. Defer initial grab_focus on delete and conflict prompts so GTK does not show a keyboard highlight until the user moves focus. Closes lgse#854
wmfeht
force-pushed
the
fix/854-permanent-delete-enter
branch
from
September 16, 2026 01:13
db3fda5 to
5e3e83f
Compare
github-actions
Bot
force-pushed
the
main
branch
4 times, most recently
from
September 17, 2026 11:50
171d7a3 to
8e043ca
Compare
added 3 commits
September 17, 2026 18:57
…elete-enter Keep main's trash confirmation unit tests alongside the Enter-focus GTK coverage.
is_recent_root used GFile::has_uri_scheme and parent(), which SIGSEGV on gphoto2 backends when tests call Location::parent concurrently.
github-actions
Bot
force-pushed
the
main
branch
6 times, most recently
from
September 20, 2026 05:00
51fba50 to
b415eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the permanent-delete confirmation, Return and keypad Enter now activate the focused button (Cancel, confirm, or Close) instead of always confirming. Initial focus remains on confirm. Left /
hstill move focus to Cancel.The Capture handler in
show_delete_confirmationuses the samehas_focus()lookup as paste/copy conflict dialogs. If no dialog button is focused, Enter proceeds sofocus_navigationcan still activate a focused control; it never falls back to confirm.Visual evidence
N/A — keyboard activation only; no layout or CSS change.
How to test
/dev/shm) to open the permanent-delete confirmation.h) until Cancel has the focus ring. Press Enter, then repeat with keypad Enter.Expected result: With Cancel or Close focused, the file stays and the dialog dismisses. With confirm focused, deletion still proceeds. Initial focus remains on confirm.
Related issue
Closes lgse#854