fix: check serverError before showing success toast#1
Open
wndzph9jkb-create wants to merge 1 commit into
Open
Conversation
- Add handleActionResult utility for centralized serverError checking
- Fix edit-workspace-name-form to check serverError before success toast
- Prevents false success toasts when server returns serverError with status 200
The bug: next-safe-action returns { serverError: '...' } as success data
because the HTTP status is 200. Components check for .data existence and
show success toasts without checking for serverError.
Closes formbricks#3302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes formbricks#3302