Stabilize node traffic role editing#5
Merged
Conversation
Keep auto-arrange from resetting in-memory node edits, normalize duplicate node traffic profiles by traffic type, and route the node editor through explicit top-level view-model bindings so traffic type and role changes remain stable across additional consumer nodes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors node traffic profile management by introducing proxy properties in MainWindowViewModel for XAML bindings and implementing a normalization process to merge duplicate traffic profiles. Additionally, the AutoArrangeNodes method was updated to modify existing node coordinates directly rather than reloading the entire network. Feedback was provided regarding a redundant conditional check in the node definition change handler.
| return; | ||
| } | ||
|
|
||
| if (!isNormalizingNodeTrafficProfiles && sender is NodeViewModel node) |
There was a problem hiding this comment.
The check !isNormalizingNodeTrafficProfiles is redundant here because the method already returns early on line 767 if this condition is true.
if (sender is NodeViewModel node)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep auto-arrange from resetting in-memory node edits, normalize duplicate node traffic profiles by traffic type, and route the node editor through explicit top-level view-model bindings so traffic type and role changes remain stable across additional consumer nodes.