Skip to content

Add Active Save File search - #326

Merged
woahitsraj merged 5 commits into
mainfrom
rajan/quick-search-focused-collection
Sep 15, 2026
Merged

woahitsraj merged 5 commits into
mainfrom
rajan/quick-search-focused-collection

Conversation

@woahitsraj

@woahitsraj woahitsraj commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a compact command-style Search for the Active Save File by species, nickname, or location.
  • Open Search with Cmd/Ctrl+K or controller Y; open the Main Menu with Cmd/Ctrl+Shift+K or controller Start.
  • Open the exact Party or Box Slot from a result and restore keyboard or controller focus.
  • Render global shortcuts in Settings from the same typed app-command registry used by input handling, including a readable narrow-screen layout.
  • Keep search local and offline, with clear empty and unavailable Save File states.

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test:unit -- --run, 456 passed
  • pnpm test:engine-smoke, 144 passed
  • pnpm exec playwright test src/routes/quick-search.e2e.ts src/routes/main-menu.e2e.ts src/routes/settings.e2e.ts, 23 passed
  • Focus and transition regression scenarios, 10 passed across 5 repetitions each
  • Full CI browser matrix, 131 passed
  • dotnet build engine/Pksx.Pkhex.Engine/Pksx.Pkhex.Engine.csproj
  • dotnet format engine/Pksx.Pkhex.Engine/Pksx.Pkhex.Engine.csproj --verify-no-changes
  • Svelte autofixer, no issues or suggestions
  • Desktop and 390px-wide browser verification

Closes #254

@woahitsraj
woahitsraj force-pushed the rajan/quick-search-focused-collection branch from dc2679e to 66d018a Compare September 14, 2026 13:47
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Cloudflare preview

Environment Link
This pull request Open preview
Staging staging.pksx.app

Updated for commit 58bfe41. View workflow run.

@woahitsraj woahitsraj changed the title Add Quick Search for focused collections Add Active Save File search Sep 14, 2026
@woahitsraj
woahitsraj force-pushed the rajan/quick-search-focused-collection branch 2 times, most recently from 7a5f831 to 88dfab1 Compare September 14, 2026 15:20
@woahitsraj
woahitsraj force-pushed the rajan/quick-search-focused-collection branch from 13d5e9a to 6fe4353 Compare September 14, 2026 16:28
@woahitsraj
woahitsraj merged commit 6c6deeb into main Sep 15, 2026
11 checks passed
@woahitsraj
woahitsraj deleted the rajan/quick-search-focused-collection branch September 15, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search the focused collection with Quick Search

1 participant