Keep save panes visible and persist theme choice - #331
Merged
Merged
Conversation
- Fix two-pane layout rendering and add Android coverage - Persist and restore theme preference across reloads
Cloudflare preview
Updated for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-color-schemewhen the user has not chosen a theme.Testing
pnpm typecheckpnpm lintpnpm test:unit -- --run, 454 tests passedPKSX_E2E_PORT=4175 pnpm exec playwright test --project=chromium src/routes/boxes-two-save.e2e.tsPKSX_E2E_PORT=4178 pnpm exec playwright test --project=chromium src/routes/settings.e2e.ts, 9 tests passedPKSX_E2E_PORT=4177 pnpm exec playwright test --project=chromium src/routes/responsive-contract.e2e.ts --grep "large caps and representative surfaces"ControllerNavigationTest#openingSecondSaveKeepsOriginalPanePaintedCloses #178
Acceptance criteria
prefers-color-schemeand resolves the theme before first paint.Evidence
Android-width side-by-side saves
How verified: imported real Emerald and Pokémon X saves at 640 × 360, opened Emerald in Boxes, then opened X beside it. Emerald remains visibly rendered in the first pane.
android-two-save-flow.mp4
The API 36 instrumentation test also samples the rendered pixels in the original pane after the second save opens.
Persisted theme override
How verified: selected Dark in Settings, reloaded the document to model native WebView recreation, and observed Settings render dark immediately after reload.
dark-theme-persists.mp4
The Settings Playwright coverage additionally verifies the system dark preference when no override exists, then verifies that an explicit light override wins after reload.