Detect the Composer cache for the Laravel PHP image - #25
Merged
Conversation
The image list that drives automatic dependency caching enumerates the Wodby PHP images but omits wodby/laravel-php, so a Laravel pipeline running composer against its own service image gets no cache mount and has to pass one by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knownImageCacheProfilesenumerates the Wodby PHP images that should get an automatic Composer cache mount —wodby/php,wodby/drupal-php,wodby/wordpress-php,wodby/php-apache,wodby/php-nginx— but omitswodby/laravel-php.The effect: a Laravel pipeline running
wodby ci run -s php -- composer installgets no cache mount and has to pass-v $HOME/.composer:...by hand, unlike every other PHP stack.Found while removing those manual mounts from the boilerplate pipelines now that caching is automatic.
laravel-boilerplateis the one that could not be cleaned up, because dropping its mount would have silently disabled its cache rather than switching it to the automatic one.Validation
go test ./cmd/wodby/ci/run/passes, with a case coveringwodby/laravel-phpalongside the existing per-image detection cases.