Skip to content

Conversation

@anhu
Copy link
Member

@anhu anhu commented Mar 28, 2025

Fixes #8597

@anhu
Copy link
Member Author

anhu commented Mar 28, 2025

jenkins retest this please
(Java crashed.)

@anhu anhu changed the title Validate asn date based on string length Validate asn date based on position of Z Mar 28, 2025
@anhu
Copy link
Member Author

anhu commented Mar 28, 2025

Jenkins retest this please

@anhu
Copy link
Member Author

anhu commented Mar 29, 2025

jenkins retest this please

@anhu anhu requested review from wolfSSL-Bot and removed request for wolfSSL-Bot March 29, 2025 06:14
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test case

@JacobBarthelmeh JacobBarthelmeh assigned anhu and unassigned wolfSSL-Bot Mar 31, 2025
@anhu anhu requested a review from JacobBarthelmeh April 4, 2025 14:47
@anhu anhu assigned JacobBarthelmeh and unassigned anhu Apr 4, 2025
@anhu anhu requested a review from SparkiDev April 4, 2025 14:49
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test case

SparkiDev
SparkiDev previously approved these changes Apr 8, 2025
@anhu
Copy link
Member Author

anhu commented Apr 22, 2025

It will always eventually succeed. Need to redesign this part so we actually record whether it was generalized or utc.

        if (GetTimeString(crl->crlList->lastDate, ASN_UTC_TIME,
            tmp, MAX_WIDTH) != WOLFSSL_SUCCESS) {
            if (GetTimeString(crl->crlList->lastDate, ASN_GENERALIZED_TIME,
            tmp, MAX_WIDTH) != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("Error getting last update date");
                return WOLFSSL_FAILURE;
            }
        }

@anhu
Copy link
Member Author

anhu commented May 12, 2025

Please do not merge. I would like to squash this once it is approved.

@anhu anhu requested a review from JacobBarthelmeh May 12, 2025 19:54
@douzzer douzzer assigned anhu and douzzer and unassigned wolfSSL-Bot May 15, 2025
@anhu anhu removed their assignment Dec 24, 2025
@anhu anhu requested a review from douzzer December 24, 2025 21:55
@anhu
Copy link
Member Author

anhu commented Dec 24, 2025

Note that all tests pass with ./configure --enable-all

@anhu
Copy link
Member Author

anhu commented Dec 24, 2025

Jenkins retest this please.

@philljj philljj self-requested a review December 29, 2025 19:04
@philljj philljj assigned philljj and unassigned douzzer Dec 29, 2025
@philljj philljj self-requested a review December 29, 2025 21:36
@philljj philljj dismissed stale reviews from douzzer and JacobBarthelmeh December 29, 2025 21:37

Requested changes were made.

@anhu anhu assigned philljj and unassigned anhu and philljj Dec 29, 2025
@philljj philljj merged commit 48ebe99 into wolfSSL:master Dec 29, 2025
382 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]:wolfSSL accepts the incorrect GeneralizedTime value.

6 participants