20251229 Coverity Dereference before Null check #9591
+211
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlm2002
force-pushed
the
coverity
branch
2 times, most recently
from
145ce01 to
9f9f3b4
Compare
add new scope, whitespace
Contributor
Author
|
retest this please jenkins: Agent offline exception |
dgarske
requested changes
Dec 30, 2025
| if (P == NULL || modulus == NULL){ | ||
| return ECC_BAD_ARG_E; | ||
| } | ||
| { |
Contributor
There was a problem hiding this comment.
The DECL_MP_INT_SIZE_DYN can be at top, this is just declaring, not allocating... that's done in NEW_MP_INT_SIZE. Then revert all the indent changes. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CID 315897 Dereference before null check - move null check to prevent dereference before null check issue