hivemind: add patch to disable automatic env loading#49284
Closed
shyim wants to merge 1 commit intowolfi-dev:mainfrom
Closed
hivemind: add patch to disable automatic env loading#49284shyim wants to merge 1 commit intowolfi-dev:mainfrom
shyim wants to merge 1 commit intowolfi-dev:mainfrom
Conversation
Contributor
|
This Pull Request is stale because it has been open for 90 days with |
Contributor
Author
|
@gaughen do you need any feedback from me? No conflicts no CR review, idk what I have missed here |
Member
|
sorry, was closing stale PRs per #49284 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Adds DarthSim/hivemind#34
to disable automatic env loading, that patch is pretty easy, would be nice if this could be integrated here, otherwise I need to do an overwrite in my own repo :(
The automatic env loading makes development container pretty bad as it's not possible to overwrite it again in userland
Related:
Pre-review Checklist
For new package PRs only
endoflife.date)For new version streams
name: ${{package.name}}-compat)provides:logical unversioned forms of the package (e.g.nodejs,nodejs-lts)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latestsuccessfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epochfield is reset to 0For PRs that add patches