chore(knip): ignore intentional root devDependencies#4
Merged
Conversation
|
✅ All tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
🧹 Unused code checkCI job (pnpm exec knip) is failing onmain. Knip reports four rootdevDependenciesas unused:This failure is pre-existing on
main(it was surfaced on the merged docs PR #3, which only touchedREADME.md), so every PR and push currently trips the knip job.Why these are intentional, not dead weight
None of these are actually removable; knip just can't see how they're used statically:
@swc/coreis an approved native build dependency inpnpm-workspace.yaml(allowBuilds), pulled in for the SWC-based tooling.cz-conventional-changelogis wired up through the commitizen config inpackage.json(config.commitizen.path).@favware/npm-deprecateis a release/maintenance CLI.@types/wsis part of the standard ecosystem type set.The sister repo
wolfstar-project/stars-components(which this monorepo is modeled after) already ignores this exact same set in itsknip.json. This change mirrors that convention rather than deleting dependencies.Change
Add the four dependencies to
ignoreDependencieson the root workspace inknip.json:Verification
pnpm exec knipnow exits0.pnpm exec oxfmt --check knip.jsonpasses.pnpm exec changeset status --since=origin/mainpasses (root-only change, no package bump needed, so no changeset).Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.Confidence Score: 5/5
This looks safe to merge.
No blocking issues were found in the changed code. The ignore list is scoped to the root workspace, and package workspace checks remain configured separately.
No files need attention.
What T-Rex did
Reviews (1): Last reviewed commit: "chore(knip): ignore intentional root dev..." | Re-trigger Greptile