fix(ui): mobile command picker and DiscordEmbed label spacing#304
Draft
RedStar071 wants to merge 13 commits into
Draft
fix(ui): mobile command picker and DiscordEmbed label spacing#304RedStar071 wants to merge 13 commits into
RedStar071 wants to merge 13 commits into
Conversation
Match Discord mobile slash-command suggestions (horizontal app rail, uppercase app labels, pill input) and restore gaps after bold embed labels when values are DiscordMention/DiscordRole components. Co-authored-by: RedStar <redstar071@proton.me>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 71.53% 71.80% +0.27%
==========================================
Files 167 170 +3
Lines 3302 3345 +43
Branches 702 705 +3
==========================================
+ Hits 2362 2402 +40
Misses 447 447
- Partials 493 496 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Also apply oxfmt class-order and template formatting tweaks. Co-authored-by: RedStar <redstar071@proton.me>
This comment has been minimized.
This comment has been minimized.
Use an unscoped strong::after rule and explicit template spaces so Type, User, Reason, and logging fields keep a gap before text and mention chips. Co-authored-by: RedStar <redstar071@proton.me>
Restore the original desktop styles as defaults and scope Discord mobile layout/input tweaks to max-md instead of inverting the base cascade. Co-authored-by: RedStar <redstar071@proton.me>
Stop rendering the WolfStar group under Frequently Used, surface Staryl's first command in that slot instead, and size the picker to five visible rows. Co-authored-by: RedStar <redstar071@proton.me>
Compose WolfStar CommandsShowcase as a Discord-like workspace (header, welcome, chat, member list, message input) and cover it with SSR/a11y tests.
This comment has been minimized.
This comment has been minimized.
Move channel header/welcome under discord/channel/, rename MessageComposer to chat-message-composer, and align the composer toolbar with Discord icons.
Group slash-command UI, shared types/utils, and tests under chat-input-command, update auto-import names, and fix knip/composer SSR assertions that were failing CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A — UI polish from Discord mobile/embed screenshots.
🧭 Context
Two showcase regressions on
/wolfstar:Type,User,Reason, logging fields) jammed into their values because Vue’s whitespace condensation drops spaces between tags, andDiscordMention/DiscordRoleare components rather than text nodes.📚 Description
mdviamax-md:/md:— no inverted mobile-first base cascade.strong::afterspace plus explicit template spaces so every embed caller keeps a gap before text and mention/role chips.Mobile command picker
Embed label spacing
Desktop command picker
Test plan
md: list on top, horizontal app rail below, pill input + sendmd+: original vertical left rail and desktop input toolspnpm lint:fix,pnpm typecheck,pnpm build:test,pnpm test:unit,pnpm test:nuxtTo show artifacts inline, enable in settings.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Confidence Score: 5/5
Safe to merge with minimal risk.
The changes are confined to showcase UI, display helpers, styling, and tests. No verified runtime, accessibility, contract, or security issue was found.
No files require special attention.
What T-Rex did
Reviews (11): Last reviewed commit: "fix(discord): update scrollbar styles an..." | Re-trigger Greptile