ci: inherit native per-arch runners from reusable publish workflow#220
Merged
Conversation
Drop the platforms/enablePlatforms overrides so image builds use the architecture-native Blacksmith runners defined in the shared workflow instead of emulating arm64 via QEMU on ubuntu-latest. Claude-Session: https://claude.ai/code/session_01Xv1EAagQkhuCRGY584Kuua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa cambia
Rimuove l'override
platforms(e il flagenablePlatforms, ormai non più usato dal reusable workflow) dalla chiamata areusable-publish-image.yml: il workflow eredita così i runner di default, ora nativi per architettura (Blacksmith amd64/arm64 — vedi wolfstar-project/.github#35).Perché
Con l'override attuale entrambe le piattaforme vengono buildate su
ubuntu-latest(amd64): la build arm64 passa per l'emulazione QEMU (lenta) e le actionuseblacksmith/*vanno in fallback sul builder locale. Con i runner nativi ogni architettura è compilata su hardware nativo, come da guida Docker multi-platform.La modifica è sicura in qualunque ordine di merge rispetto a wolfstar-project/.github#35: anche i vecchi default funzionano senza override.
https://claude.ai/code/session_01Xv1EAagQkhuCRGY584Kuua
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.What T-Rex did
Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant Trigger as GitHub trigger participant Caller as wolfstar workflow participant Reusable as reusable-publish-image.yml participant Runner as Default per-arch runner participant GHCR as GHCR Trigger->>Caller: push/workflow_dispatch Caller->>Reusable: uses workflow with inherited secrets Note over Caller,Reusable: No caller-level platforms override Reusable->>Runner: select default platform runners Runner->>Reusable: build image for configured architectures Reusable->>GHCR: publish image tag%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant Trigger as GitHub trigger participant Caller as wolfstar workflow participant Reusable as reusable-publish-image.yml participant Runner as Default per-arch runner participant GHCR as GHCR Trigger->>Caller: push/workflow_dispatch Caller->>Reusable: uses workflow with inherited secrets Note over Caller,Reusable: No caller-level platforms override Reusable->>Runner: select default platform runners Runner->>Reusable: build image for configured architectures Reusable->>GHCR: publish image tagReviews (1): Last reviewed commit: "ci: inherit native per-arch runners from..." | Re-trigger Greptile