[kata/root/M001/S01] feat(S01): Bump toml 0.8 → 1.1 and fix load_vector() parsing#84
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Rust test infrastructure in crates/cupel to remain compatible with newer toml parsing behavior while bumping the dev-dependency version.
Changes:
- Bump
tomldev-dependency from0.8to1.1for thecupelcrate. - Fix TOML conformance vector loading to parse documents as
toml::Tableand wrap them astoml::Value::Table. - Extend
.gitignorewith additional common auto-generated build/cache directories.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/cupel/tests/count_constrained_knapsack.rs |
Updates load_vector() to parse TOML documents via toml::Table then wrap into Value::Table. |
crates/cupel/tests/conformance.rs |
Applies the same load_vector() TOML document parsing fix used by the main conformance test harness. |
crates/cupel/Cargo.toml |
Bumps toml dev-dependency to 1.1. |
.gitignore |
Adds baseline ignores for common generated artifacts (Node/Python/build outputs/caches). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
See slice plan: S01: Bump toml & Fix Test Infrastructure
Must-Haves
crates/cupel/Cargo.tomlhastoml = "1.1"in dev-dependenciesload_vector()inconformance.rsusestoml::from_str::<toml::Table>()wrapped inValue::Tableload_vector()incount_constrained_knapsack.rsuses the same patterncargo test— 266+ pass, 0 failcargo clippy— no new warningsTasks