Skip to content

[kata/root/M001/S01] feat(S01): Bump toml 0.8 → 1.1 and fix load_vector() parsing#84

Merged
wollax merged 2 commits into
mainfrom
kata/root/M001/S01
Mar 29, 2026
Merged

[kata/root/M001/S01] feat(S01): Bump toml 0.8 → 1.1 and fix load_vector() parsing#84
wollax merged 2 commits into
mainfrom
kata/root/M001/S01

Conversation

@wollax
Copy link
Copy Markdown
Owner

@wollax wollax commented Mar 29, 2026

What Changed

See slice plan: S01: Bump toml & Fix Test Infrastructure

Must-Haves

  • crates/cupel/Cargo.toml has toml = "1.1" in dev-dependencies
  • load_vector() in conformance.rs uses toml::from_str::<toml::Table>() wrapped in Value::Table
  • load_vector() in count_constrained_knapsack.rs uses the same pattern
  • cargo test — 266+ pass, 0 fail
  • cargo clippy — no new warnings

Tasks

  • T01: Bump toml to 1.1 and fix both load_vector() call sites

Copilot AI review requested due to automatic review settings March 29, 2026 20:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Rust test infrastructure in crates/cupel to remain compatible with newer toml parsing behavior while bumping the dev-dependency version.

Changes:

  • Bump toml dev-dependency from 0.8 to 1.1 for the cupel crate.
  • Fix TOML conformance vector loading to parse documents as toml::Table and wrap them as toml::Value::Table.
  • Extend .gitignore with additional common auto-generated build/cache directories.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
crates/cupel/tests/count_constrained_knapsack.rs Updates load_vector() to parse TOML documents via toml::Table then wrap into Value::Table.
crates/cupel/tests/conformance.rs Applies the same load_vector() TOML document parsing fix used by the main conformance test harness.
crates/cupel/Cargo.toml Bumps toml dev-dependency to 1.1.
.gitignore Adds baseline ignores for common generated artifacts (Node/Python/build outputs/caches).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wollax wollax merged commit cdfe264 into main Mar 29, 2026
5 checks passed
@wollax wollax deleted the kata/root/M001/S01 branch March 29, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants